Skip to content

chore: fix storybook#7444

Merged
speaker-ender merged 3 commits intomainfrom
chore/fix-storybook
Feb 23, 2026
Merged

chore: fix storybook#7444
speaker-ender merged 3 commits intomainfrom
chore/fix-storybook

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Feb 20, 2026

Ticket []

Description Of Changes

Should fix storybook if you are on a newer node version.
Updating some dependencies in the meantime.

Code Changes

  • Updating storybook
  • Removing custom code to find framework package needed for older versions of node
  • Fixing imports so that stories display correct styles
  • Updating additional storybook packages
  • Fixes module resolution for types

Steps to Confirm

  1. Run turbo run storybook from the clients directory
  2. Confirm that storybook runs and opens without error

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required
    • * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ] * [ ]

@vercel
Copy link
Contributor

vercel bot commented Feb 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Feb 23, 2026 5:25pm
fides-privacy-center Ignored Ignored Feb 23, 2026 5:25pm

Request Review

@speaker-ender speaker-ender force-pushed the chore/fix-storybook branch 2 times, most recently from 69102ad to b53713e Compare February 23, 2026 14:36
@speaker-ender speaker-ender marked this pull request as ready for review February 23, 2026 14:37
@speaker-ender speaker-ender requested a review from a team as a code owner February 23, 2026 14:37
@speaker-ender speaker-ender requested review from gilluminate and kruulik and removed request for a team February 23, 2026 14:37
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 23, 2026

Greptile Summary

Updated Storybook from v9.1.15 to v10.2.10 to fix compatibility issues with newer Node versions. The getAbsolutePath helper function was removed from the Storybook configuration as it's no longer needed in Storybook v10, which handles framework package resolution automatically. Additional dependencies were added including msw (Mock Service Worker v2.12.10) and vite (v7.3.1) to support the new Storybook version.

  • Updated @storybook/react-vite and storybook packages from v9 to v10
  • Removed custom getAbsolutePath helper that was needed for monorepo support in older Storybook versions
  • Added missing peer dependencies (msw, vite) required by Storybook v10
  • One minor cleanup needed: unused imports in main.ts

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward dependency updates to fix Storybook compatibility. The only issue is a minor code cleanup (unused imports) that doesn't affect functionality. The upgrade follows the intended migration path from Storybook v9 to v10.
  • No files require special attention beyond the minor import cleanup noted

Important Files Changed

Filename Overview
clients/fidesui/.storybook/main.ts Removed getAbsolutePath helper for newer Storybook version, but left unused imports
clients/fidesui/package.json Updated Storybook from v9 to v10 and added required dependencies (msw, vite)

Last reviewed commit: b53713e

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@speaker-ender speaker-ender force-pushed the chore/fix-storybook branch 3 times, most recently from fd57de2 to 6259e72 Compare February 23, 2026 15:28
speaker-ender and others added 2 commits February 23, 2026 11:58
chore: remove code

chore: update changelog

chore: remove extra imports

fix: imports

chore: another import fix

chore: actual fix
Copy link
Contributor

@kruulik kruulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed working locally. Using turbo 2.4.4 npm 11.8.0 and node 24.13.1

@speaker-ender speaker-ender added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit 5bf5e96 Feb 23, 2026
40 of 41 checks passed
@speaker-ender speaker-ender deleted the chore/fix-storybook branch February 23, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants