ENG-2753: Gate DSR Policies behind beta flag#7460
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile SummaryThis PR successfully gates the DSR Policies feature behind a new beta flag and resolves a route collision by moving pages to a top-level route. The implementation is clean and follows established patterns. Key changes:
What works well:
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 2851ffb |
Additional Comments (1)
Then update the SearchInput: <SearchInput
placeholder="Search policies by name or key..."
onChange={updateSearch}
value={searchQuery}
className="max-w-md"
/>Context Used: Rule from |
lucanovera
left a comment
There was a problem hiding this comment.
Works as expected, code changes look good. Approved!
Ticket ENG-2753
Description Of Changes
Gate the DSR Policies feature behind a new beta flag and reorder it to appear last in the "Privacy requests" nav group. Also moves the policies pages to a top-level
/privacy-request-policiesroute to avoid collision with the/privacy-requests/[id]dynamic route.policiesbeta flag: enabled in dev/test, disabled in production/privacy-requests/policiesto/privacy-request-policiesCode Changes
clients/admin-ui/src/flags.json- Addedpoliciesbeta flag definitionclients/admin-ui/src/features/common/nav/nav-config.tsx- Reordered Policies to last, addedrequiresFlag: "policies"clients/admin-ui/src/features/common/nav/routes.ts- Updated route paths to/privacy-request-policiesclients/admin-ui/src/pages/privacy-request-policies/index.tsx- Moved fromprivacy-requests/policies/clients/admin-ui/src/pages/privacy-request-policies/[key].tsx- Moved fromprivacy-requests/policies/Steps to Confirm
Expected: "Policies" nav item appears as the last item under Privacy requests
Expected: Navigates to
/privacy-request-policiesand displays the policies listExpected: Navigates to
/privacy-request-policies/[key]and displays the policy detail pageExpected: "Policies" nav item disappears as the last item under Privacy requests
/privacy-request-policiesby pasting it in the URL barExpected: With the flag off, route should redirect to home
Pre-Merge Checklist
CHANGELOG.mdupdatedMade with Cursor