Integration modal UX improvements#7491
Conversation
Single-click integration selection: Clicking an integration card now navigates directly to the configuration form, eliminating the intermediate "select then click Next" two-step flow. The "Details" path (card detail view with its own Next button) is unchanged. Modal title updated: First screen now reads "Select an integration" instead of "Add integration". Footer removed from list view: The list screen no longer shows Cancel/Next buttons. Footer with Back/Save only appears on the detail and form steps. Fixed search/filter bar: The search input and category dropdown sit in a non-scrolling zone above the card grid. Cards scroll independently beneath it. Consistent modal height: The modal is a fixed 700px tall across all steps -- no height jump when transitioning between list view (no footer) and form view (with footer). Chakra to Ant/Tailwind migration: Replaced the Chakra FormModal wrapper with Ant Design Modal in AddIntegrationModal. Replaced Chakra layout primitives (Box, Flex, Text, Wrap) with plain divs + Tailwind utilities in SelectableIntegrationBox, including hover states and keyboard accessibility (role="button", tabIndex, onKeyDown). The configuration form internals (ConfigureIntegrationForm) are intentionally untouched to avoid validation/submission risk.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile SummaryThis PR improves the integration modal UX by enabling single-click integration selection, updating modal title to "Select an integration", fixing the search/filter bar position, and maintaining consistent 700px modal height. The implementation successfully migrates from Chakra UI's FormModal to Ant Design Modal and extracts filter logic into a reusable custom hook. Key changes:
Issues found:
Confidence Score: 3/5
Important Files Changed
Last reviewed commit: 5dde3c2 |
clients/admin-ui/src/features/integrations/add-integration/AddIntegrationModal.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/add-integration/AddIntegrationModal.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/add-integration/AddIntegrationModal.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/add-integration/SelectIntegrationType.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/add-integration/SelectIntegrationType.tsx
Outdated
Show resolved
Hide resolved
gilluminate
left a comment
There was a problem hiding this comment.
Ant migration stuff needs a lot of clean up. Likely need to update to our latest FE ruleset for cursor
|
@gilluminate I got Jades script working on my local repo and removed my local cursor rules that conflict. I ran that through my changed files and commit those changes. Let me know what you think. |
gilluminate
left a comment
There was a problem hiding this comment.
@jack-gale-ethyca much better! Thanks for doing that. We're really close, just a few more nit-picky items (we still need to add these to our rules!)
clients/admin-ui/src/features/integrations/add-integration/SelectIntegrationType.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/add-integration/AddIntegrationModal.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/add-integration/AddIntegrationModal.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/add-integration/AddIntegrationModal.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/add-integration/SelectIntegrationType.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/add-integration/SelectIntegrationType.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/SelectableIntegrationBox.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/SelectableIntegrationBox.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
…IntegrationModal.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>
…IntegrationModal.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>
…IntegrationModal.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>
…ectIntegrationType.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>
…onBox.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>
…onBox.tsx Co-authored-by: Jason Gill <jason.gill@ethyca.com>
|
@gilluminate We should be good to go, all checks are passing and I made all the updates you requested. |
gilluminate
left a comment
There was a problem hiding this comment.
Looks great! Ship it
Ticket ENG-2695
Description Of Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works