Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
f7e4337 to
9ff173a
Compare
chore: even more stories chore: more stories and refinements chore: even more components chore: linting chore: a lot more stories chore: lint chore: more stories feat: rough dark mode support chore: more stories lots of clean ups and additions chore: linting feat: sorted navigation feat: table args chore: clean ups chore: more storeies and refactors chore: more storybook chore: message stories
5c6fbed to
b266c0c
Compare
Greptile SummaryThis PR adds comprehensive Storybook stories for fidesui components to improve documentation, enable visual regression testing with Chromatic, and enhance component discoverability. The implementation includes the Key Changes:
Issues Found:
Note on PR Size: Confidence Score: 4/5
Important Files Changed
Last reviewed commit: b266c0c |
clients/fidesui/src/components/typography/Paragraph.stories.tsx
Outdated
Show resolved
Hide resolved
clients/fidesui/src/components/typography/Paragraph.stories.tsx
Outdated
Show resolved
Hide resolved
kruulik
left a comment
There was a problem hiding this comment.
Excellent! The storybook utilities are great.
Ticket []
Description Of Changes
Adding more storybook stories to fidesui with the following goals:
fidesuifidesuiImplementation notes:
index.tsxfile when possible. The reason is that we want to represent components in the same way that a user of the package would see.Primarystories are for showing the default state and the minimum required arguments for displaying the component. They are also for allowing configuration of the component in storybook via controls.fidesui. We want to avoid relying on internal ant types/code as much as possible to avoid extra work.This also adds the
a11yplugin to storybook for more comprehensive accessibility testing.Code Changes
Steps to Confirm
indexinstead of directly from antfidesuiand aren't using ant defaultsPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works