Conversation
- Add Sparkline component using recharts AreaChart - Add Sparkline stories for Storybook - Export Sparkline and SparklineProps from fidesui - Add recharts dependency to fidesui
- Add RadarChart component using recharts RadarChart - Add RadarChart stories for Storybook - Export RadarChart, RadarChartProps, and RadarChartDataPoint from fidesui - Add recharts dependency to fidesui
…nto karolis-sparkline
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Greptile SummaryThis PR adds a new Key observations:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 7b2775c |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
@gilluminate (since you're already here) is the PR line limit a hard block? I'm not over by that much (557/500). If it is, I'll probably need to move the storybook-related work into a separate PR. |
|
@kruulik No, it's more of a guideline/reminder. Merging won't be blocked by that. |
…into karolis-radarchart
|
@gilluminate addressed your comments |
gilluminate
left a comment
There was a problem hiding this comment.
Looks good to me. The updates are clean and address the feedback well. Ship it.
Ticket []
Description Of Changes
Creates a new RadarChart component. Refactors some charting logic to be shareable. Improves storybook UI to demonstrate light and dark modes.
Code Changes
Steps to Confirm
turbo run storybookand check the Chart componentsPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works