Fix system search in integration form modal#7511
Merged
Conversation
- Forward onSearch in ControlledSelect when provided (not only in tags mode) so the system dropdown refetches with the typed search term. - Disable client-side filterOption for system select so results come from API search by name. - ConnectionStatusNotice: wrap 'Connection not tested' in Flex for alignment. Made-with: Cursor
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Contributor
Greptile SummaryFixed system search functionality in the integration form modal by properly passing the
Confidence Score: 5/5
Important Files Changed
Last reviewed commit: af5a2dd |
gilluminate
approved these changes
Feb 26, 2026
Contributor
gilluminate
left a comment
There was a problem hiding this comment.
Works well in Vercel testing
jpople
added a commit
that referenced
this pull request
Feb 27, 2026
jpople
added a commit
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2831
Description Of Changes
Fixed search behavior in the integration form modal being incorrect. The
onSearchprop wasn't being passed through theControlledSelect, so options weren't being refetched and instead searching was only happening locally and filtering on value instead of name (desired).Also includes a small alignment fix in the connection test status box.
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works