Skip to content

Fix system search in integration form modal#7511

Merged
jpople merged 1 commit intomainfrom
jpople/ENG-2831/integration-system-search-fix
Feb 26, 2026
Merged

Fix system search in integration form modal#7511
jpople merged 1 commit intomainfrom
jpople/ENG-2831/integration-system-search-fix

Conversation

@jpople
Copy link
Contributor

@jpople jpople commented Feb 26, 2026

Ticket ENG-2831

Description Of Changes

Fixed search behavior in the integration form modal being incorrect. The onSearch prop wasn't being passed through the ControlledSelect, so options weren't being refetched and instead searching was only happening locally and filtering on value instead of name (desired).

Also includes a small alignment fix in the connection test status box.

Steps to Confirm

  1. Add some systems using the bulk system add
  2. Create an integration (e.g. BigQuery)
  3. View the integration's detail page
  4. Click "manage"; inside the form, the system select should refetch its options list after a short debounce when you search

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

- Forward onSearch in ControlledSelect when provided (not only in tags mode)
  so the system dropdown refetches with the typed search term.
- Disable client-side filterOption for system select so results come from
  API search by name.
- ConnectionStatusNotice: wrap 'Connection not tested' in Flex for alignment.

Made-with: Cursor
@jpople jpople requested a review from a team as a code owner February 26, 2026 22:10
@jpople jpople requested review from gilluminate and removed request for a team February 26, 2026 22:10
@vercel
Copy link
Contributor

vercel bot commented Feb 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 26, 2026 10:10pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 26, 2026 10:10pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 26, 2026

Greptile Summary

Fixed system search functionality in the integration form modal by properly passing the onSearch prop through ControlledSelect. Previously, the component only enabled search handling in tags mode, causing server-side search to be ignored and filtering to happen only locally on values instead of names.

  • Modified ControlledSelect to respect the onSearch prop when provided, enabling server-side search for any select component
  • Added filterOption={false} to the system select in ConfigureIntegrationForm to disable client-side filtering when using server-side search
  • Fixed alignment in ConnectionStatusNotice by wrapping "Connection not tested" text in a Flex component for consistency

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are focused bug fixes with clear intent: enabling server-side search by properly passing through the onSearch prop, disabling client-side filtering when server-side search is active, and a small alignment fix for consistency. The logic is straightforward and addresses a specific issue without introducing complexity or side effects.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/common/form/ControlledSelect.tsx Fixed onSearch prop handling to support server-side search by checking if onSearch is provided OR if mode is tags
clients/admin-ui/src/features/integrations/ConnectionStatusNotice.tsx Wrapped 'Connection not tested' text in Flex component for consistent alignment with other status messages
clients/admin-ui/src/features/integrations/add-integration/ConfigureIntegrationForm.tsx Added filterOption={false} to disable client-side filtering when using server-side search

Last reviewed commit: af5a2dd

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in Vercel testing

@jpople jpople added this pull request to the merge queue Feb 26, 2026
Merged via the queue into main with commit a97ed85 Feb 26, 2026
42 of 43 checks passed
@jpople jpople deleted the jpople/ENG-2831/integration-system-search-fix branch February 26, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants