ENG-2699: CSS fixes for TCF embedded consent in mobile SDK#7513
Merged
thabofletcher merged 8 commits intomainfrom Mar 3, 2026
Merged
ENG-2699: CSS fixes for TCF embedded consent in mobile SDK#7513thabofletcher merged 8 commits intomainfrom
thabofletcher merged 8 commits intomainfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Greptile SummaryThis PR adds CSS overrides to
The changes are scoped to CSS in a single static HTML file used exclusively for embedded mobile SDK WebViews. No JavaScript logic or data handling is modified. The layout fixes are straightforward CSS adjustments with no complex interactions. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: b5638cd |
Co-authored-by: Thabo Fletcher <thabofletcher@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
gilluminate
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2699
Description Of Changes
CSS fixes for TCF embedded consent in mobile SDK WebViews to support both dismissable and non-dismissable
banner_and_modalexperiences.Code Changes
clients/privacy-center/public/embedded-consent.html:dismissablesetting.Steps to Confirm
embedded-consent.html?geolocation=de&property_id=FDS-C33DQM(any TCF region, and your property ID instead)dismissable=trueanddismissable=falseexperience configs (if possible, reporting client uses dismissable=true so that is the more critical testPre-Merge Checklist
CHANGELOG.mdupdated