Skip to content

fix: website monitor added tab filter [ENG-2420]#7516

Merged
speaker-ender merged 1 commit intomainfrom
fix/website-monitor-added-tab-filter--ENG-2420
Feb 27, 2026
Merged

fix: website monitor added tab filter [ENG-2420]#7516
speaker-ender merged 1 commit intomainfrom
fix/website-monitor-added-tab-filter--ENG-2420

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Feb 27, 2026

Ticket ENG-2420

Description Of Changes

Adds the systemId filter to the added tab for website monitors for correct scoping of request

Code Changes

Steps to Confirm

  1. Visit a website monitor in the action center
  2. Navigate to a system within the website monitor
  3. Click on the Added tab
  4. Confirm that only results from the current system are being displayed

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 27, 2026 4:17pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 27, 2026 4:17pm

Request Review

@speaker-ender speaker-ender force-pushed the fix/website-monitor-added-tab-filter--ENG-2420 branch from e7adc5b to 9b615ae Compare February 27, 2026 16:12
@speaker-ender speaker-ender marked this pull request as ready for review February 27, 2026 16:53
@speaker-ender speaker-ender requested a review from a team as a code owner February 27, 2026 16:53
@speaker-ender speaker-ender requested review from jpople and removed request for a team February 27, 2026 16:53
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

This PR fixes a bug where the "Added" tab in website monitors was missing the system filter, causing it to display results from all systems instead of just the current system. The fix adds system: systemId to the "Added" tab configuration, making it consistent with the "Attention required" and "Ignored" tabs which already had this filter.

  • Fixed missing system: systemId filter in the "Added" tab configuration
  • Change ensures all three tabs (Attention required, Added, Ignored) now consistently filter by system
  • Simple one-line fix that resolves the scoping issue described in the ticket

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects a straightforward bug fix with a single-line change that adds consistency across tab filters. The change is well-scoped, aligns with existing patterns in the code, and includes appropriate changelog documentation
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useActionCenterTabs.tsx Added missing system filter to "Added" tab for proper scoping - aligns with existing tabs

Last reviewed commit: 9b615ae

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@speaker-ender speaker-ender added this pull request to the merge queue Feb 27, 2026
Merged via the queue into main with commit 9b6d578 Feb 27, 2026
43 checks passed
@speaker-ender speaker-ender deleted the fix/website-monitor-added-tab-filter--ENG-2420 branch February 27, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants