Skip to content

Revert "add debug logging for connection get endpoint"#7517

Merged
adamsachs merged 1 commit intomainfrom
revert-7514-asachs/debug-connection-get
Feb 27, 2026
Merged

Revert "add debug logging for connection get endpoint"#7517
adamsachs merged 1 commit intomainfrom
revert-7514-asachs/debug-connection-get

Conversation

@adamsachs
Copy link
Contributor

Reverts #7514

This was only meant for diagnostic/debugging purposes, removing those updates now.

@adamsachs adamsachs requested a review from a team as a code owner February 27, 2026 19:09
@adamsachs adamsachs requested review from JadeCara and removed request for a team February 27, 2026 19:09
@vercel
Copy link
Contributor

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Feb 27, 2026 7:09pm
fides-privacy-center Ignored Ignored Feb 27, 2026 7:09pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

This PR cleanly reverts debug logging and performance instrumentation added in PR #7514. The changes remove temporary diagnostic code that was used to investigate performance issues with the connection listing endpoint.

Key Changes:

  • Removed performance timing instrumentation across multiple modules (time.perf_counter() calls and associated logging)
  • Removed temporary /connection_legacy endpoint that was added for A/B performance comparison
  • Restored simplified transformer lambda in get_connections endpoint
  • Removed Redis performance counter utilities (perf_reset_redis_counters, perf_get_redis_counters)
  • Cleaned up imports (time, Sequence, unnecessary logger imports)

The revert is complete and restores the codebase to its clean state before the debug changes.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • This is a clean revert of temporary debug code that was explicitly added for diagnostic purposes. All changes remove instrumentation code without affecting application logic. The revert is complete and restores the original functionality.
  • No files require special attention

Important Files Changed

Filename Overview
src/fides/api/api/v1/endpoints/connection_endpoints.py Removed debug logging and temporary /connection_legacy endpoint, restored clean transformer lambda
src/fides/api/schemas/connection_configuration/connection_config.py Removed performance timing instrumentation from mask_sensitive_values method, restored original comment
src/fides/api/util/connection_type.py Removed performance timing from get_connection_type_secret_schema and get_saas_connection_types
src/fides/api/util/redis_version_cache.py Removed performance counter utilities and timing instrumentation for Redis calls

Last reviewed commit: 88f8512

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@adamsachs adamsachs enabled auto-merge February 27, 2026 19:15
@adamsachs adamsachs added this pull request to the merge queue Feb 27, 2026
Merged via the queue into main with commit c9f6866 Feb 27, 2026
53 of 54 checks passed
@adamsachs adamsachs deleted the revert-7514-asachs/debug-connection-get branch February 27, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants