Skip to content

Update privacy request layout visuals#7518

Merged
jpople merged 19 commits intomainfrom
jpople/eng-2848/request-verification-layout-updates
Feb 27, 2026
Merged

Update privacy request layout visuals#7518
jpople merged 19 commits intomainfrom
jpople/eng-2848/request-verification-layout-updates

Conversation

@jpople
Copy link
Contributor

@jpople jpople commented Feb 27, 2026

Ticket ENG-2848

Description Of Changes

Update layout for privacy requests, ID verification, and manual tasks portal to use centered card layout.

Screenshot 2026-02-27 at 13 07 29 Screenshot 2026-02-27 at 13 07 35

Code Changes

  • Rewrite AuthFormLayout component to match old ExternalAuthLayout component
  • Removed showTitleOnDesktop prop (all callers were passing true)

Steps to Confirm

  1. Update your privacy center config so identity verification is required
  2. Make a privacy request, verify page layout for request form, success, and verification page matches designs
  3. View the external tasks portal, verify page layout matches designs

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@jpople jpople requested a review from a team as a code owner February 27, 2026 19:19
@jpople jpople requested review from speaker-ender and removed request for a team February 27, 2026 19:19
@vercel
Copy link
Contributor

vercel bot commented Feb 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Feb 27, 2026 10:11pm
fides-privacy-center Ignored Ignored Feb 27, 2026 10:11pm

Request Review

@jpople jpople requested review from lucanovera and removed request for speaker-ender February 27, 2026 19:19
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

This PR refactors the AuthFormLayout component to use a centered card layout with inline styles instead of Tailwind classes, removing the showTitleOnDesktop prop that was always set to true. However, there are two critical logic issues:

  • Broken responsive display: The desktop title is hardcoded with display: "none" (always hidden) and the mobile title has no responsive hiding logic (always shown), despite comments indicating responsive behavior
  • Ignored maxWidth prop: The inner container has hardcoded maxWidth: "512px" instead of using the className prop, breaking layouts that expect 640px width

These issues will prevent the layout from matching the intended design specifications.

Confidence Score: 2/5

  • Not safe to merge - contains logic bugs that will cause incorrect display behavior
  • Two critical logic bugs prevent proper responsive layout and width control. The desktop title will never show and all layouts will be constrained to 512px regardless of the className prop passed.
  • Pay close attention to clients/privacy-center/components/common/AuthFormLayout.tsx - contains broken responsive display logic and hardcoded maxWidth that ignores the className prop

Important Files Changed

Filename Overview
clients/privacy-center/components/common/AuthFormLayout.tsx Rewritten with inline styles and new layout structure, but responsive display logic is broken - desktop title always hidden, mobile title always shown
clients/privacy-center/app/privacy-request/[actionKey]/page.tsx Removed showTitleOnDesktop prop - simple cleanup change
clients/privacy-center/components/privacy-request/RequestSubmittedPage.tsx Added preview={false} to Image component to prevent unwanted preview modal

Last reviewed commit: 4d94603

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@jpople jpople enabled auto-merge February 27, 2026 21:53
Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! It looks way better, responsiveness is good. All edge cases are handled. Code looks good. Approved.

return (
<LoadServerEnvironmentIntoStores serverEnvironment={serverEnvironment}>
<AuthFormLayout
showTitleOnDesktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additional cleanup

@jpople jpople added this pull request to the merge queue Feb 27, 2026
Merged via the queue into main with commit a232584 Feb 27, 2026
38 of 40 checks passed
@jpople jpople deleted the jpople/eng-2848/request-verification-layout-updates branch February 27, 2026 22:22
jpople added a commit that referenced this pull request Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants