Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
mfbrown
force-pushed
the
feature/add-es-us-language
branch
from
e7dac78 to
373c131
Compare
Contributor
|
@mfbrown all of the problems here are stemming from work done 4 months ago on |
mfbrown
force-pushed
the
feature/add-es-us-language
branch
from
65b1d2d to
4acd52f
Compare
mfbrown
requested review from
erosselli,
gilluminate and
lucanovera
and removed request for
a team
Contributor
Greptile SummaryThis PR adds Key observations:
Confidence Score: 4/5
Important Files Changed
Last reviewed commit: 8848a46 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| @@ -0,0 +1,26 @@ | |||
| { | |||
| "static.tcf.consent": "Consentimiento", | |||
| "static.tcf.cookie_disclosure.also_non_cookie": "Este proveedor también una otros métodos como “almacenamiento local” para almacenar y acceder a información en su dispositivo.", | |||
Contributor
There was a problem hiding this comment.
Inherited typo in translation
The phrase "también una otros métodos" contains a typo — "una" should be "usa" (meaning "uses"). The same issue exists in the es-MX source file this was copied from. Since this PR explicitly creates es-US from es-MX, this is a good opportunity to fix it here (and optionally in es-MX too).
Suggested change
| "static.tcf.cookie_disclosure.also_non_cookie": "Este proveedor también una otros métodos como “almacenamiento local” para almacenar y acceder a información en su dispositivo.", | |
| "static.tcf.cookie_disclosure.also_non_cookie": "Este proveedor también usa otros métodos como \u201calmacenamiento local\u201d para almacenar y acceder a información en su dispositivo.", |
Comment on lines
+1
to
+26
| { | ||
| "static.tcf.consent": "Consentimiento", | ||
| "static.tcf.cookie_disclosure.also_non_cookie": "Este proveedor también una otros métodos como “almacenamiento local” para almacenar y acceder a información en su dispositivo.", | ||
| "static.tcf.cookie_disclosure.intro": "almacena cookies con una duración máxima de alrededor de estos días.", | ||
| "static.tcf.cookie_disclosure.non_cookie": "usa métodos como “almacenamiento local” para almacenar y acceder a información en su dispositivo.", | ||
| "static.tcf.cookie_disclosure.refresh": "Estas cookies se pueden actualizar.", | ||
| "static.tcf.data_categories": "Categorías de datos", | ||
| "static.tcf.features": "Características", | ||
| "static.tcf.features.description": "A continuación, encontrará una lista de las características para las que se están procesando sus datos. Puede ejercer sus derechos para las características especiales usando los botones a continuación.", | ||
| "static.tcf.legint": "Interés legítimo", | ||
| "static.tcf.legint_disclosure": "Divulgación de interés legítimo", | ||
| "static.tcf.privacy_policy": "Política de privacidad", | ||
| "static.tcf.purposes": "Propósitos", | ||
| "static.tcf.purposes.description": "A continuación, encontrará una lista de los propósitos y características especiales para los que se están procesando sus datos. Puede ejercer sus derechos para propósitos específicos, basándose en el consentimiento o interés legítimo, usando los botones a continuación.", | ||
| "static.tcf.retention": "Retención", | ||
| "static.tcf.retention_period_days": "día(s)", | ||
| "static.tcf.special_features": "Características especiales", | ||
| "static.tcf.special_purposes": "Propósitos especiales", | ||
| "static.tcf.vendors": "Proveedores", | ||
| "static.tcf.vendors.description": "A continuación, encontrará una lista de los proveedores que procesan sus datos y los propósitos o características de procesamiento que ellos declaran. Puede ejercer sus derechos para cada proveedor basándose en la base legal que afirman.", | ||
| "static.tcf.vendors.iab": "Proveedores IAB TCF", | ||
| "static.tcf.vendors.other": "Otros proveedores", | ||
| "static.tcf.vendors_count": "proveedor(es)", | ||
| "static.tcf.vendors_using_consent": "Proveedores que usan consentimiento", | ||
| "static.tcf.vendors_using_legint": "Proveedores que usan interés legítimo" | ||
| } |
Contributor
There was a problem hiding this comment.
Missing translation key static.tcf.iab
The English reference locale (en/messages-tcf.json) includes the key "static.tcf.iab": "IAB TCF", which is absent from both es-MX and this new es-US file. This is a pre-existing gap inherited from es-MX. Since es-US is being created fresh here, it would be a good opportunity to add it:
"static.tcf.iab": "IAB TCF",(The value is an acronym so no translation is needed.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2843
Description Of Changes
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works