ENG-2916: Bump tinycss2 from 1.2.1 to >=1.5.0#7601
Conversation
Loosen the tinycss2 pin to unblock a weasyprint upgrade in fidesplus. The fides usage of tinycss2 (parse_stylesheet and FunctionBlock in unsafe_file_util.py) is unchanged between 1.2.1 and 1.5.x. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
📝 WalkthroughWalkthroughUpdated the tinycss2 dependency in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
pyproject.toml (1)
113-113: Consider adding an upper bound to follow defensive versioning best practices.While the tinycss2 APIs used here (
parse_stylesheetandFunctionBlock) are stable across the 1.x series and tinycss2 follows semantic versioning (breaking changes only with major version bumps), using>=1.5.0without an upper bound allows future major versions to be installed. For greater safety, constrain to>=1.5.0,<2.0or use~=1.5.0to allow patches within the 1.x line while preventing unexpected major version upgrades.♻️ Suggested fix
- "tinycss2>=1.5.0", + "tinycss2>=1.5.0,<2.0",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` at line 113, Update the tinycss2 dependency specification to include an upper bound to prevent automatic major upgrades; replace the current "tinycss2>=1.5.0" requirement with a constrained spec such as "tinycss2>=1.5.0,<2.0" or a compatible release spec like "tinycss2~=1.5.0" so that code using tinycss2 (e.g., calls to parse_stylesheet and uses of FunctionBlock) stays on the stable 1.x API surface.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@pyproject.toml`:
- Line 113: Update the tinycss2 dependency specification to include an upper
bound to prevent automatic major upgrades; replace the current "tinycss2>=1.5.0"
requirement with a constrained spec such as "tinycss2>=1.5.0,<2.0" or a
compatible release spec like "tinycss2~=1.5.0" so that code using tinycss2
(e.g., calls to parse_stylesheet and uses of FunctionBlock) stays on the stable
1.x API surface.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b1dc890e-da31-4c45-b4da-e20bc2aaacfd
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Ticket ENG-2916
Description Of Changes
Loosens the
tinycss2pin from==1.2.1to>=1.5.0to unblock a weasyprint upgrade in fidesplus. The fides usage of tinycss2 (parse_stylesheet()andFunctionBlockinunsafe_file_util.py) is unchanged between 1.2.1 and 1.5.x — no breaking API changes.Code Changes
pyproject.toml: Changetinycss2==1.2.1→tinycss2>=1.5.0uv.lock: Regenerated (tinycss2 1.2.1 → 1.5.1)Steps to Confirm
from tinycss2 import parse_stylesheetandfrom tinycss2.ast import FunctionBlockstill workunsafe_file_util.pyrelated tests if any existPre-Merge Checklist
CHANGELOG.mdupdatedSummary by CodeRabbit