Skip to content

Fix Alert banner variant to use Carbon icons #7627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gilluminate merged 4 commits into from
Mar 12, 2026
Merged

Fix Alert banner variant to use Carbon icons #7627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fdb29a
fix: Alert banner variant now uses Carbon icons
gilluminate Mar 11, 2026
719ab46
Simplify CustomAlert banner defaults for consistency
gilluminate Mar 12, 2026
82a9ac7
fix formatting
gilluminate Mar 12, 2026
84a6af1
Update Alert.stories.tsx
gilluminate Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions clients/fidesui/src/components/feedback/Alert.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,16 @@ export const Banner: Story = {
description: PARAGRAPH_LOREM,
banner: true,
},
argTypes: {
type: {
control: "select",
options: Object.values(ALERT_TYPE),
},
showIcon: {
control: "boolean",
},
icon: iconControl,
},
};

export const Compact: Story = {
Expand Down
11 changes: 10 additions & 1 deletion clients/fidesui/src/hoc/CustomAlert.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,12 @@ export interface CustomAlertProps extends AlertProps {}

const withCustomProps = (WrappedComponent: typeof Alert) => {
const WrappedAlert = React.forwardRef<AlertRef, CustomAlertProps>(
({ showIcon, icon, type = "info", description, ...props }, ref) => {
(
{ showIcon = false, icon, type = "info", banner, description, ...props },
ref,
) => {
// Override Ant's banner-specific defaults so all alert types
// behave consistently.
const carbonIcon =
showIcon && icon === undefined
? getDefaultAlertIcon(type, !!description)
Expand All @@ -20,6 +25,7 @@ const withCustomProps = (WrappedComponent: typeof Alert) => {
showIcon={showIcon}
icon={carbonIcon}
type={type}
banner={banner}
description={description}
{...props}
/>
Expand All @@ -39,6 +45,9 @@ const withCustomProps = (WrappedComponent: typeof Alert) => {
* injected based on the alert `type`. Icons are sized at 16px for compact
* alerts and 24px when a `description` is present.
*
* Banner mode (`banner={true}`) uses the same defaults as all other alert
* types (`showIcon=false`, `type="info"`), overriding Ant's internal defaults.
*
* All standard Alert props are supported. Passing a custom `icon` overrides
* the Carbon default.
*/
Expand Down
Loading