Skip to content

[ENG-3039] - Remove system scanner code from the UI#7704

Merged
johnewart merged 3 commits intomainfrom
johnewart/remove-system-scanner-ui
Mar 19, 2026
Merged

[ENG-3039] - Remove system scanner code from the UI#7704
johnewart merged 3 commits intomainfrom
johnewart/remove-system-scanner-ui

Conversation

@johnewart
Copy link
Collaborator

@johnewart johnewart commented Mar 19, 2026

Ticket ENG-3039

Description Of Changes

Removes the system scanner functionality from the UI since it has been removed from the backend

Code Changes

  • Removes pages and tests that rely on the system scanner backend API

Steps to Confirm

N/A - should be automated and this is removing code

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@johnewart johnewart requested a review from a team as a code owner March 19, 2026 19:42
@johnewart johnewart requested review from jpople and removed request for a team March 19, 2026 19:42
@vercel
Copy link
Contributor

vercel bot commented Mar 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Mar 19, 2026 9:01pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Mar 19, 2026 9:01pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 19, 2026

Greptile Summary

This PR cleanly removes the Kubernetes/Pixie cluster-based system scanner feature from the UI, following the removal of the corresponding backend API. All related components (DataFlowScannerOption, LoadDataFlowScanner, DataFlowScannerLogo), RTK Query endpoints (updateScan, getLatestScanDiff), type models (SystemScanHistory, SystemScanResponse, SystemScannerStatus, SystemsDiff), test fixtures, and feature flags (dataFlowScanning) are correctly deleted. The skipped Cypress test suite is replaced with a minimal active test verifying the add-systems page works with Plus health.

Key findings:

  • The ClusterHealth enum (in both clients/admin-ui/src/types/api/models/ClusterHealth.ts and clients/privacy-center/types/api/models/ClusterHealth.ts) was only consumed by SystemScannerStatus, which was deleted in this PR. Both files and their index.ts re-exports are now orphaned dead code and should be removed as a follow-up.
  • This PR touches 32 files with ~2,855 line changes. Per project guidelines, PRs should be under 15 files and 500 line changes. While the large scope is expected for a wholesale removal of dead code, it is worth noting for awareness.

Confidence Score: 4/5

  • This PR is safe to merge — it removes dead code with no functional regressions expected.
  • All system scanner UI code has been consistently and thoroughly removed. The one point deduction is for the orphaned ClusterHealth enum left behind in both client packages, which is minor dead code but does not cause any runtime issues.
  • clients/admin-ui/src/types/api/index.ts and clients/privacy-center/types/api/index.ts — both still export the now-unused ClusterHealth enum.

Important Files Changed

Filename Overview
clients/admin-ui/src/types/api/index.ts Removes exports for SystemScanHistory, SystemScannerStatus, SystemScanResponse, and SystemsDiff, but the ClusterHealth export (line 94) was only used by SystemScannerStatus and is now orphaned dead code.
clients/privacy-center/types/api/index.ts Mirrors admin-ui changes — removes SystemScan* exports but leaves the ClusterHealth export (line 61) which is now dead code since SystemScannerStatus was its sole consumer.
clients/admin-ui/src/features/plus/plus.slice.ts Cleanly removes the updateScan mutation, getLatestScanDiff query, selectDataFlowScannerStatus selector, and associated type imports. No issues found.
clients/admin-ui/src/features/common/features/features.slice.ts Cleanly removes dataFlowScanning feature flag and its derivation from plusHealth.system_scanner. No issues found.
clients/admin-ui/src/features/config-wizard/AddSystem.tsx Removes DataFlowScannerOption button and updates description text to reflect AWS/Okta-only automated discovery. Cleanup is consistent.
clients/admin-ui/cypress/e2e/config-wizard-plus.cy.ts Previously a large, fully-skipped test suite; now an active minimal test that verifies the add-systems page loads correctly with Plus health. Good replacement.

Comments Outside Diff (1)

  1. clients/admin-ui/src/types/api/index.ts, line 94 (link)

    P2 Orphaned ClusterHealth export

    ClusterHealth was only ever used by SystemScannerStatus, which was deleted in this PR. The enum itself (models/ClusterHealth.ts) and its export here are now dead code that wasn't cleaned up.

    The same issue exists in clients/privacy-center/types/api/index.ts at line 61.

    Consider removing:

    • clients/admin-ui/src/types/api/models/ClusterHealth.ts
    • export { ClusterHealth } from "./models/ClusterHealth"; in clients/admin-ui/src/types/api/index.ts
    • clients/privacy-center/types/api/models/ClusterHealth.ts
    • export { ClusterHealth } from "./models/ClusterHealth"; in clients/privacy-center/types/api/index.ts

Last reviewed commit: "Remove system scanne..."

@gilluminate
Copy link
Contributor

gilluminate commented Mar 19, 2026

Minor cleanup note. The PR deletes SystemScannerStatus.ts (the only consumer of ClusterHealth) but leaves behind orphaned files:

  • clients/admin-ui/src/types/api/models/ClusterHealth.ts
  • clients/privacy-center/types/api/models/ClusterHealth.ts
  • export { ClusterHealth } in both index.ts barrel files

@johnewart johnewart added this pull request to the merge queue Mar 19, 2026
Merged via the queue into main with commit b5ce49d Mar 19, 2026
45 of 46 checks passed
@johnewart johnewart deleted the johnewart/remove-system-scanner-ui branch March 19, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants