Skip to content

feat: infra monitor details tray [ENG-3119]#7857

Merged
speaker-ender merged 3 commits into
mainfrom
feat/infra-monitor-details-tray--ENG-3119
Apr 24, 2026
Merged

feat: infra monitor details tray [ENG-3119]#7857
speaker-ender merged 3 commits into
mainfrom
feat/infra-monitor-details-tray--ENG-3119

Conversation

@speaker-ender
Copy link
Copy Markdown
Contributor

@speaker-ender speaker-ender commented Apr 8, 2026

Ticket ENG-3119

Description Of Changes

  • Added a drawer for Idp monitor results in the action center
  • Allowing item actions from within details drawer
  • Allowing editing of descriptions from within details drawer

Code Changes

Steps to Confirm

  1. Create an idp monitor
  2. Go to the action center and navigate to that monitor screen
  3. Click the title of a monitor result
  4. Verify that the details are displayed correctly for that system
  5. Test that updating the data uses and descriptions from within the details drawer function correctly

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Apr 24, 2026 1:51pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Apr 24, 2026 1:51pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 9, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.31% (2799/44303) 5.56% (1402/25209) 4.41% (579/13105)
fides-js Coverage: 78%
79.39% (2011/2533) 65.99% (1240/1879) 73.09% (345/472)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

@speaker-ender speaker-ender force-pushed the feat/infra-monitor-details-tray--ENG-3119 branch 2 times, most recently from dead0bb to a3bc479 Compare April 16, 2026 13:22
@speaker-ender speaker-ender force-pushed the feat/infra-monitor-details-tray--ENG-3119 branch 2 times, most recently from d14a041 to a963d1f Compare April 21, 2026 13:05
@speaker-ender speaker-ender force-pushed the feat/infra-monitor-details-tray--ENG-3119 branch from a963d1f to f4233eb Compare April 21, 2026 13:30
@speaker-ender speaker-ender force-pushed the feat/infra-monitor-details-tray--ENG-3119 branch from f4233eb to b450338 Compare April 21, 2026 16:36
@speaker-ender speaker-ender marked this pull request as ready for review April 21, 2026 16:39
@speaker-ender speaker-ender requested a review from a team as a code owner April 21, 2026 16:39
@speaker-ender speaker-ender requested review from gilluminate and removed request for a team April 21, 2026 16:39
@speaker-ender speaker-ender force-pushed the feat/infra-monitor-details-tray--ENG-3119 branch from b450338 to fe5e93b Compare April 21, 2026 16:44
Comment on lines +150 to +155
<Text>
{"preferred_description" in item &&
typeof item.preferred_description === "string"
? item.preferred_description
: ""}
</Text>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to do a bit of digging to see what this was all about. Seems that preferred_description is just not being auto-generated in the API response types? Should we just extend that Type instead of adding this complexity?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm willing to add it as an extension if you think that's best.
Even though ugly, this is safer and won't break the FE if there is a BE change to the types and we continue using our modified types.

Copy link
Copy Markdown
Contributor

@gilluminate gilluminate Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we just saying that if preferred_description goes missing, nothing breaks? If so, doesn't that obfuscate the problem instead of an error letting us know there's a problem? Regardless, I think item.preferred_description ?? "" would prevent an error.

Copy link
Copy Markdown
Contributor Author

@speaker-ender speaker-ender Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not just protecting if preferred_description goes missing, it's also protecting if the type changes to something that can't be rendered to the dom and causes a crash.
IMO the ideal solution (outside of the BE fixing the types) would be to have a runtime transformer that allows us to centralize the patches + run validation so we can have graceful fallbacks and try to set up some kind of notification that the types are wrong.
I tend to lean toward obfuscations that don't crash in production if not caught over a little less visibility into missing renders.
Totally open to arguments to the contrary

wip: actions and editability

chore: linting

wip: more actiohn stuff

wip: updating on demand

wip: getting something working

chore: update types

chore: lots of fixes

chore: more api updates

chore: clean ups

chore: rename file

chore: more removals

chore: more fixes for now

chore: filtering out hidden actions

wip: refactoring visual

wip: functioning

chore: updating api

chore: all the fixes

refactor: styles and organization

wip: refactor data use

chore: functional data uses

chore: file renaming

chore: update changelog

refactor: skip request when no run provided

refactor: data use to be functional

chore: code cleanups
fix: incorrect pr number

refactor: remove expandable text
@speaker-ender speaker-ender force-pushed the feat/infra-monitor-details-tray--ENG-3119 branch from e76193c to 70dd3bd Compare April 24, 2026 13:49
@speaker-ender speaker-ender added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit b84dcbd Apr 24, 2026
53 checks passed
@speaker-ender speaker-ender deleted the feat/infra-monitor-details-tray--ENG-3119 branch April 24, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants