ENG-3364: Fix Request Manager list alignment#7874
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
lucanovera
left a comment
There was a problem hiding this comment.
Nice simple fix. Confirmed it in chrome and firefox. Approved.
There was a problem hiding this comment.
Code Review
This is a minimal, targeted fix. The change is correct.
What the change does: Ant Design's <Spin> renders as display: inline-block by default, which causes it to shrink-wrap its content and center itself within the parent <Flex>. Adding className="w-full" overrides this to width: 100%, making the spinner wrapper fill the available horizontal space and keeping the list flush with the container edges.
No issues found. The fix is scoped appropriately to the problem, does not affect the loading skeleton path (which uses a separate <div className="p-2"> wrapper), and does not introduce any layout regressions for the pagination or filter controls rendered outside the <Spin> wrapper.
LGTM.
Ticket ENG-3364
Description Of Changes
Fixes excessive whitespace on the sides of the Request Manager list view. The
<Spin>wrapper was centered and shrank to fit its content, pulling the list away from the screen edges. Addingw-fullcauses it to expand to fill the available width.Code Changes
className="w-full"to the<Spin>component wrapping the requests list inPrivacyRequestsDashboardSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdated