Skip to content

ENG-3364: Fix Request Manager list alignment#7874

Merged
jpople merged 1 commit intomainfrom
jpople/eng-3364/request-manager-margin-fix
Apr 9, 2026
Merged

ENG-3364: Fix Request Manager list alignment#7874
jpople merged 1 commit intomainfrom
jpople/eng-3364/request-manager-margin-fix

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Apr 9, 2026

Ticket ENG-3364

Description Of Changes

Fixes excessive whitespace on the sides of the Request Manager list view. The <Spin> wrapper was centered and shrank to fit its content, pulling the list away from the screen edges. Adding w-full causes it to expand to fill the available width.

Code Changes

  • Added className="w-full" to the <Spin> component wrapping the requests list in PrivacyRequestsDashboard

Steps to Confirm

  1. Navigate to the Request Manager page
  2. Verify the list spans the full width with no extra whitespace on the sides

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • No UX review needed
  • Followup issues:
    • No followup issues
  • Database migrations:
    • No migrations
  • Documentation:
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Apr 9, 2026 4:43pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Apr 9, 2026 4:43pm

Request Review

@jpople jpople marked this pull request as ready for review April 9, 2026 16:43
@jpople jpople requested a review from a team as a code owner April 9, 2026 16:43
@jpople jpople requested review from gilluminate and lucanovera and removed request for a team and lucanovera April 9, 2026 16:43
Copy link
Copy Markdown
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple fix. Confirmed it in chrome and firefox. Approved.

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a minimal, targeted fix. The change is correct.

What the change does: Ant Design's <Spin> renders as display: inline-block by default, which causes it to shrink-wrap its content and center itself within the parent <Flex>. Adding className="w-full" overrides this to width: 100%, making the spinner wrapper fill the available horizontal space and keeping the list flush with the container edges.

No issues found. The fix is scoped appropriately to the problem, does not affect the loading skeleton path (which uses a separate <div className="p-2"> wrapper), and does not introduce any layout regressions for the pagination or filter controls rendered outside the <Spin> wrapper.

LGTM.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 7%
5.88% (2547/43305) 4.89% (1199/24515) 3.95% (508/12829)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.93% (330/384) 81.1% (176/217) 78.87% (56/71)

@jpople jpople enabled auto-merge April 9, 2026 16:51
@jpople jpople added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit 9bde58e Apr 9, 2026
52 of 53 checks passed
@jpople jpople deleted the jpople/eng-3364/request-manager-margin-fix branch April 9, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants