Skip to content

ENG-3388: use correct confidence bucket query parameter#7895

Merged
tvandort merged 2 commits intomainfrom
ENG-3388
Apr 14, 2026
Merged

ENG-3388: use correct confidence bucket query parameter#7895
tvandort merged 2 commits intomainfrom
ENG-3388

Conversation

@tvandort
Copy link
Copy Markdown
Contributor

@tvandort tvandort commented Apr 10, 2026

Ticket ENG-3388

Description Of Changes

Fixes an incorrect query parameter being used in an href.

Code Changes

  • Change query parameter name.

Steps to Confirm

  1. Click on findings underneath a monitor run with classifications.
  2. Ensure that the correct confidence bucket is populated and filtered to.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@tvandort tvandort requested a review from a team as a code owner April 10, 2026 18:29
@tvandort tvandort requested review from speaker-ender and removed request for a team April 10, 2026 18:29
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Apr 10, 2026 6:31pm
fides-privacy-center Ignored Ignored Apr 10, 2026 6:31pm

Request Review

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Scope: Frontend (TypeScript/React) — one functional change in ConfidenceCard.tsx, plus a changelog entry.


Summary

This is a clean, targeted bug fix. The query parameter name was confidenceBucket (camelCase) but the receiving page (fields/page.tsx) reads query.confidence_bucket (snake_case), so the filter was never being applied when navigating from the confidence card. The fix correctly aligns the key to confidence_bucket.

Verification: The snake_case form is used consistently throughout the codebase — in MonitorFieldSearchFormQueryState (parseAsArrayOf for confidence_bucket), in fields/page.tsx line 111, in monitor-fields.slice.ts, and in the API types (DatastoreMonitorResourcesDynamicFilters.confidence_bucket). The old confidenceBucket key had no consumers, confirming it was a silent mismatch.


Findings

No issues found. The change is minimal, correct, and well-scoped.

The changelog entry is properly formatted with the right type: Fixed classification.


🔬 Codegraph: connected (46297 nodes)


💡 Write /code-review in a comment to re-run this review.

@github-actions
Copy link
Copy Markdown

Title Lines Statements Branches Functions
admin-ui Coverage: 7%
5.87% (2547/43385) 4.89% (1203/24598) 3.94% (508/12861)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.93% (330/384) 81.1% (176/217) 78.87% (56/71)

@tvandort tvandort added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit 9321ed4 Apr 14, 2026
51 checks passed
@tvandort tvandort deleted the ENG-3388 branch April 14, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants