Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
There was a problem hiding this comment.
Code Review
Scope: Frontend (TypeScript/React) — one functional change in ConfidenceCard.tsx, plus a changelog entry.
Summary
This is a clean, targeted bug fix. The query parameter name was confidenceBucket (camelCase) but the receiving page (fields/page.tsx) reads query.confidence_bucket (snake_case), so the filter was never being applied when navigating from the confidence card. The fix correctly aligns the key to confidence_bucket.
Verification: The snake_case form is used consistently throughout the codebase — in MonitorFieldSearchFormQueryState (parseAsArrayOf for confidence_bucket), in fields/page.tsx line 111, in monitor-fields.slice.ts, and in the API types (DatastoreMonitorResourcesDynamicFilters.confidence_bucket). The old confidenceBucket key had no consumers, confirming it was a silent mismatch.
Findings
No issues found. The change is minimal, correct, and well-scoped.
The changelog entry is properly formatted with the right type: Fixed classification.
🔬 Codegraph: connected (46297 nodes)
💡 Write /code-review in a comment to re-run this review.
Ticket ENG-3388
Description Of Changes
Fixes an incorrect query parameter being used in an href.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works