Fix duplicated authentication description on Okta integration page#7899
Fix duplicated authentication description on Okta integration page#7899dsill-ethyca merged 2 commits intomainfrom
Conversation
Remove the second, hardcoded "Authentication:" paragraph that duplicated the content already rendered via OKTA_AUTH_DESCRIPTION. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review: Fix duplicated authentication description on Okta integration page
Overall: Clean, minimal, correct fix. No issues found.
Summary
The change removes a hardcoded <InfoText> block that duplicated the "Authentication:" section already rendered via the OKTA_AUTH_DESCRIPTION constant. The two blocks had slightly diverging text:
- Removed (hardcoded): "…You'll need to create an API Services application in Okta and generate an RSA key pair."
- Kept (via constant): "…You will need to generate an RSA key in Okta and copy the JSON key to use in Fides."
The kept version is more accurate and consistent with how the rest of the codebase manages this copy (through the exported constant). Removing the hardcoded duplicate is the right call — it also means future updates to the auth description only need to be made in one place.
No functional, architectural, or security concerns.
🔬 Codegraph: connected (46297 nodes)
💡 Write /code-review in a comment to re-run this review.
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 participants
Summary
OktaIntegrationOverviewcomponent had two<InfoText>blocks with nearly identical auth descriptions — one using theOKTA_AUTH_DESCRIPTIONconstant and a second with hardcoded textTest plan
🤖 Generated with Claude Code