Skip to content

ENG-3430: make privacy center actions optional#7919

Merged
nreyes-dev merged 6 commits intomainfrom
nreyes/eng-3430
Apr 14, 2026
Merged

ENG-3430: make privacy center actions optional#7919
nreyes-dev merged 6 commits intomainfrom
nreyes/eng-3430

Conversation

@nreyes-dev
Copy link
Copy Markdown
Contributor

@nreyes-dev nreyes-dev commented Apr 14, 2026

Ticket ENG-3430

Description Of Changes

Privacy Center fails to start when config.json has an empty actions array (or omits it entirely). This blocks customers who only use Privacy Center to serve fides.js and don't need DSR action tiles. This change makes actions optional, defaulting to [].

Code Changes

  • Removed the non-empty array validation check for actions in the Privacy Center config validator
  • Made actions optional (defaulting to []) in the PrivacyCenterConfig and PartialPrivacyCenterConfig Pydantic schemas
  • Updated TypeScript types (Config, LegacyConfig, API PrivacyCenterConfig) to mark actions as optional
  • Added ?? [] guards where components iterate over config.actions

Steps to Confirm

Config file path:

  1. Set "actions": [] in clients/privacy-center/config/config.json
  2. Start the Privacy Center — it should load without errors
  3. The home page should render with no action tiles (consent card still appears if configured)

API config path:

  1. Create/update a property via the API with privacy_center_config that has no actions key (or "actions": [])
  2. Set USE_API_CONFIG=true and start the Privacy Center — it should load without errors

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Apr 14, 2026 9:26pm
fides-privacy-center Ignored Ignored Apr 14, 2026 9:26pm

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.06%. Comparing base (330f838) to head (6c50c1d).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7919      +/-   ##
==========================================
- Coverage   85.06%   85.06%   -0.01%     
==========================================
  Files         629      629              
  Lines       40855    40855              
  Branches     4748     4748              
==========================================
- Hits        34753    34752       -1     
- Misses       5029     5030       +1     
  Partials     1073     1073              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.1% (2663/43652) 5.22% (1293/24750) 4.19% (542/12919)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

@nreyes-dev nreyes-dev marked this pull request as ready for review April 14, 2026 21:14
@nreyes-dev nreyes-dev requested review from a team as code owners April 14, 2026 21:14
@nreyes-dev nreyes-dev requested review from adamsachs and kruulik and removed request for a team April 14, 2026 21:14
claude[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, manually tested both API path and hardcoded config and privacy center loads as expected.

@nreyes-dev nreyes-dev added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit 989f3ee Apr 14, 2026
69 checks passed
@nreyes-dev nreyes-dev deleted the nreyes/eng-3430 branch April 14, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants