Skip to content

Update type generation command to use heyapi #7920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucanovera merged 1 commit into from
Apr 14, 2026
+2 −2
Merged

Update type generation command to use heyapi #7920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clients/admin-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
"lint": "eslint --fix .",
"lint:ci": "eslint .",
"lint-staged:fix": "lint-staged --diff=main",
"openapi:generate": "openapi --input http://localhost:8080/openapi.json --output ./src/types/api --exportCore false --exportServices false --indent 2 && prettier --write .",
"openapi:generate-dictionary": "openapi --input http://localhost:8081/openapi.json --output ./src/types/dictionary-api --exportCore false --exportServices false --indent 2",
"openapi:generate": "openapi-ts --file openapi-ts-api.config.ts",
Copy link
Copy Markdown
Contributor

@claude claude Bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clients/admin-ui/package.json:29

The old command ran prettier --write . after code generation. The new config handles formatting via format: "prettier" in openapi-ts-api.config.ts, so that's covered for the API types. Just worth confirming the prettier formatting output is equivalent — particularly that the same files are reformatted (the old command targeted ., the new one targets only the generated output path).

"openapi:generate-dictionary": "openapi-ts --file openapi-ts-dictionary.config.ts",
Copy link
Copy Markdown
Contributor

@claude claude Bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clients/admin-ui/package.json:30

openapi-ts-dictionary.config.ts uses a types top-level key (types.enums, types.identifierCase) while openapi-ts-api.config.ts uses the plugins array (@hey-api/typescript with enums and case). These look like different API versions of @hey-api/openapi-ts. With the installed version ^0.88.2, the types key may be silently ignored or produce a deprecation warning. Consider aligning the dictionary config to use the same plugins-based API as the main config to ensure the enum generation settings actually take effect.

"start": "next start",
"test": "jest",
"test:watch": "jest --watchAll",
Expand Down
Loading