Skip to content

ENG-3437: Change account dropdown to click-only trigger#7923

Merged
gilluminate merged 3 commits intomainfrom
gill/ENG-3437/change-hover-to-click-logout
Apr 14, 2026
Merged

ENG-3437: Change account dropdown to click-only trigger#7923
gilluminate merged 3 commits intomainfrom
gill/ENG-3437/change-hover-to-click-logout

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate commented Apr 14, 2026

Ticket ENG-3437

Description Of Changes

The account dropdown menu at the bottom of the main sidebar nav previously opened on both hover and click. This changes it to click-only, preventing accidental activation when hovering past the user icon.

Also deletes a dead file (not used anywhere)

Code Changes

  • Changed the Ant Design <Dropdown> trigger prop from ["click", "hover"] to ["click"] in AccountDropdownMenu.tsx
  • Deleted TestMessagingProviderConnectionButton.tsx

Steps to Confirm

  1. Log in to the admin UI
  2. Hover over the user icon at the bottom of the nav sidebar -- the dropdown should not appear
  3. Click the user icon -- the dropdown should appear with the username and "Sign out" option
  4. Click "Sign out" -- should log out successfully

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Apr 14, 2026 9:22pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Apr 14, 2026 9:22pm

Request Review

@gilluminate gilluminate force-pushed the gill/ENG-3437/change-hover-to-click-logout branch from 8232b2c to b0ce13b Compare April 14, 2026 21:17
gilluminate and others added 3 commits April 14, 2026 15:18
The account dropdown menu in the bottom nav previously opened on both
hover and click, which could cause accidental activation. Now it only
opens on click for a more intentional interaction.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@gilluminate gilluminate force-pushed the gill/ENG-3437/change-hover-to-click-logout branch from 7e9582b to 5d7daa2 Compare April 14, 2026 21:18
@gilluminate gilluminate marked this pull request as ready for review April 14, 2026 21:19
@gilluminate gilluminate requested a review from a team as a code owner April 14, 2026 21:19
@gilluminate gilluminate requested review from jpople and removed request for a team April 14, 2026 21:19
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a dead file (not being used anywhere)

Copy link
Copy Markdown
Contributor

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This is a clean, minimal PR with two independent changes bundled appropriately.

AccountDropdownMenu.tsx — trigger change

The one-line change from trigger={["click", "hover"]} to trigger={["click"]} is correct and straightforward. Removing "hover" eliminates accidental activation when the cursor passes over the user icon in the sidebar. No accessibility regressions — the button retains tabIndex={0} for keyboard navigation and the click interaction is preserved.

TestMessagingProviderConnectionButton.tsx — dead code deletion

Confirmed: a full codebase search finds zero imports or references to this component anywhere under clients/admin-ui/src. The deletion is safe. The component also depended on Chakra UI + Formik patterns that are being migrated away from, so removing it is doubly appropriate.

Changelog

Entry in changelog/7923-click-only-account-dropdown.yaml is correctly typed as Changed and matches the described behavior change.

Minor observations (non-blocking)

  • The deleted component included a useCreateTestConnectionMessageMutation call from messaging.slice. Worth confirming the mutation itself is still exercised elsewhere if it was ever used in production — but given the component had no call sites, this is likely fine.
  • No tests were added or removed, which is appropriate for this scope of change.

Overall: LGTM. The changes are focused, low-risk, and well-described.

🔬 Codegraph: connected (46711 nodes)


💡 Write /code-review in a comment to re-run this review.

@github-actions
Copy link
Copy Markdown

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.1% (2663/43634) 5.22% (1293/24734) 4.19% (542/12916)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.93% (330/384) 81.1% (176/217) 78.87% (56/71)

@gilluminate gilluminate added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit f364cd5 Apr 14, 2026
52 checks passed
@gilluminate gilluminate deleted the gill/ENG-3437/change-hover-to-click-logout branch April 14, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants