ENG-3437: Change account dropdown to click-only trigger#7923
ENG-3437: Change account dropdown to click-only trigger#7923gilluminate merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
8232b2c to
b0ce13b
Compare
The account dropdown menu in the bottom nav previously opened on both hover and click, which could cause accidental activation. Now it only opens on click for a more intentional interaction. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
7e9582b to
5d7daa2
Compare
There was a problem hiding this comment.
This was a dead file (not being used anywhere)
There was a problem hiding this comment.
Code Review
This is a clean, minimal PR with two independent changes bundled appropriately.
AccountDropdownMenu.tsx — trigger change
The one-line change from trigger={["click", "hover"]} to trigger={["click"]} is correct and straightforward. Removing "hover" eliminates accidental activation when the cursor passes over the user icon in the sidebar. No accessibility regressions — the button retains tabIndex={0} for keyboard navigation and the click interaction is preserved.
TestMessagingProviderConnectionButton.tsx — dead code deletion
Confirmed: a full codebase search finds zero imports or references to this component anywhere under clients/admin-ui/src. The deletion is safe. The component also depended on Chakra UI + Formik patterns that are being migrated away from, so removing it is doubly appropriate.
Changelog
Entry in changelog/7923-click-only-account-dropdown.yaml is correctly typed as Changed and matches the described behavior change.
Minor observations (non-blocking)
- The deleted component included a
useCreateTestConnectionMessageMutationcall frommessaging.slice. Worth confirming the mutation itself is still exercised elsewhere if it was ever used in production — but given the component had no call sites, this is likely fine. - No tests were added or removed, which is appropriate for this scope of change.
Overall: LGTM. The changes are focused, low-risk, and well-described.
🔬 Codegraph: connected (46711 nodes)
💡 Write /code-review in a comment to re-run this review.
Ticket ENG-3437
Description Of Changes
The account dropdown menu at the bottom of the main sidebar nav previously opened on both hover and click. This changes it to click-only, preventing accidental activation when hovering past the user icon.
Also deletes a dead file (not used anywhere)
Code Changes
<Dropdown>triggerprop from["click", "hover"]to["click"]inAccountDropdownMenu.tsxSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works