Skip to content

ENG-3406: fix stale sidebar data in action center#7960

Merged
nreyes-dev merged 2 commits intomainfrom
nreyes/eng-3406
Apr 20, 2026
Merged

ENG-3406: fix stale sidebar data in action center#7960
nreyes-dev merged 2 commits intomainfrom
nreyes/eng-3406

Conversation

@nreyes-dev
Copy link
Copy Markdown
Contributor

@nreyes-dev nreyes-dev commented Apr 20, 2026

Ticket ENG-3406

Description Of Changes

Fixes stale sidebar data in the Action Center's datastore classifying monitor page. The refresh button only invalidated the Monitor Field Results RTK Query tag (used by the table) but not the Monitor Field Details tag (used by the sidebar drawer), so a drawer reopened shortly after a refresh could serve a cached response. This brings the refresh button in line with how other action-center mutations (e.g. classify/mute) already invalidate both tags.

Code Changes

  • Updated the refresh handler in clients/admin-ui/src/pages/data-discovery/action-center/datastore/[monitorId]/index.tsx to invalidate Monitor Field Details in addition to Monitor Field Results.

Steps to Confirm

  1. Navigate to a datastore classifying monitor's Action Center results page (/data-discovery/action-center/datastore/<monitorId>) that has at least one classified field.
  2. Open browser DevTools → Network tab and filter by fetch/XHR.
  3. Click any field row to open the details sidebar. Observe that a GET request to the field details endpoint (useGetStagedResourceDetailsQuery) fires and the sidebar renders with its data.
  4. Close the sidebar.
  5. Click the refresh button at the top of the page. Observe that the fields list endpoint refetches.
  6. Click the same field row again to reopen the sidebar.
  7. Confirm that a new GET request to the field details endpoint fires (without this fix, no request fires and the sidebar displays stale cached data).

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Apr 20, 2026 5:35am
fides-privacy-center Ignored Ignored Apr 20, 2026 5:35am

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.17% (2709/43841) 5.38% (1340/24891) 4.24% (550/12962)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

@nreyes-dev nreyes-dev marked this pull request as ready for review April 20, 2026 06:02
@nreyes-dev nreyes-dev requested a review from a team as a code owner April 20, 2026 06:02
@nreyes-dev nreyes-dev requested review from gilluminate and removed request for a team April 20, 2026 06:02
claude[bot]

This comment was marked as resolved.

@nreyes-dev nreyes-dev added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main with commit 7c9889b Apr 20, 2026
52 checks passed
@nreyes-dev nreyes-dev deleted the nreyes/eng-3406 branch April 20, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants