Skip to content

ENG-3417: Fix browser nav for action center ignored assets#7961

Merged
eastandwestwind merged 3 commits intomainfrom
ENG-3417
Apr 20, 2026
Merged

ENG-3417: Fix browser nav for action center ignored assets#7961
eastandwestwind merged 3 commits intomainfrom
ENG-3417

Conversation

@eastandwestwind
Copy link
Copy Markdown
Contributor

https://ethyca.atlassian.net/browse/ENG-3417

Description Of Changes

  • Fixes browser navigation for the Action Center ignored/monitored assets page by using the active tab's diff_status filter instead of hardcoding DiffStatus.ADDITION
  • Preserves the active tab context (via URL hash) when navigating back to the system view, so users don't lose their place when the system query returns no results

Code Changes

  • Replace hardcoded DiffStatus.ADDITION filter with the active tab's diff_status
  • Preserve active tab via URL hash on navigation back
  • Add activeTab to useEffect dependency array

Steps to Confirm

  1. Start up Admin-UI with seed data
  2. Navigate to Action Center → select the Ethyca.com website monitor → In the system list, select "Uncategorized Assets" and click "ignore"
  3. Switch to the "Ignored" tab, Click "Uncategorized Assets" and confirm it navigates to those uncategorized assets instead of going back to the higher-level Ethyca.com system list

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Apr 20, 2026 1:42pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Apr 20, 2026 1:42pm

Request Review

eastandwestwind and others added 2 commits April 20, 2026 15:36
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.17% (2709/43842) 5.38% (1340/24891) 4.24% (550/12962)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

@eastandwestwind eastandwestwind marked this pull request as ready for review April 20, 2026 13:57
@eastandwestwind eastandwestwind requested a review from a team as a code owner April 20, 2026 13:57
@eastandwestwind eastandwestwind requested review from lucanovera and removed request for a team April 20, 2026 13:57
Copy link
Copy Markdown
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed in the preview link that the bug is fixed! Ship it.
Image

@eastandwestwind eastandwestwind added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main with commit fc41b34 Apr 20, 2026
51 checks passed
@eastandwestwind eastandwestwind deleted the ENG-3417 branch April 20, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants