Skip to content

Fix sample app builds after Next upgrade#7966

Merged
gilluminate merged 4 commits intomainfrom
gill/fix/sample-app-builds
Apr 20, 2026
Merged

Fix sample app builds after Next upgrade#7966
gilluminate merged 4 commits intomainfrom
gill/fix/sample-app-builds

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

Description Of Changes

The sample app (clients/sample-app) was failing to build after the Next.js upgrade. This PR fixes the build by:

  • Upgrading next, react, react-dom, and related dependencies to compatible versions
  • Replacing the removed swcMinify config option with outputFileTracingRoot
  • Simplifying outputFileTracingRoot to use __dirname directly instead of path.join(__dirname)
  • Updating tsconfig.json to align with the new Next.js version requirements
  • Updating types.d.ts image module declaration

Code Changes

  • Updated clients/sample-app/package.json and package-lock.json with upgraded dependencies
  • Replaced deprecated swcMinify: true with outputFileTracingRoot: __dirname in next.config.js
  • Updated tsconfig.json compiler options for Next.js compatibility
  • Updated types.d.ts image module declaration

Steps to Confirm

  1. cd clients/sample-app && npm run build completes successfully
  2. npm run dev starts the dev server without errors
  3. Sample app pages render correctly at localhost:3001

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

gilluminate and others added 2 commits April 20, 2026 12:47
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Apr 20, 2026 6:58pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Apr 20, 2026 6:58pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 20, 2026

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
See the Details below.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 64d4ae0.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

  • clients/sample-app/package-lock.json
  • clients/sample-app/package.json

@gilluminate gilluminate marked this pull request as ready for review April 20, 2026 18:52
@gilluminate gilluminate requested a review from a team as a code owner April 20, 2026 18:52
@gilluminate gilluminate requested review from jpople and removed request for a team April 20, 2026 18:52
@github-actions
Copy link
Copy Markdown

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.29% (2771/44007) 5.5% (1376/25009) 4.41% (575/13024)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

@gilluminate gilluminate added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main with commit ad0c2ba Apr 20, 2026
46 checks passed
@gilluminate gilluminate deleted the gill/fix/sample-app-builds branch April 20, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants