ENG-3481: Assessment template versioning schema + new templates#7969
Merged
ENG-3481: Assessment template versioning schema + new templates#7969
Conversation
Add template versioning support with fides_revision, is_managed, and parent_template_id columns. Remove deprecated key column. Add unique constraint on (assessment_type, version, fides_revision). New/updated templates: - CPRA v2025: Updated to reflect final CPPA rules (47 questions, 16 sections) - EU AI Act FRIA v2026: Updated for Article 27 obligations (24 questions, 6 sections) - UK ICO ROPA: New (42 questions, 15 sections) - IE DPC ROPA: New (41 questions, 15 sections) - FR CNIL ROPA: New (38 questions, 16 sections) Old CPRA and FRIA versions are deactivated (is_active=false), preserving existing assessments linked to them. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7969 +/- ##
=======================================
Coverage 85.04% 85.04%
=======================================
Files 631 631
Lines 41213 41217 +4
Branches 4807 4807
=======================================
+ Hits 35049 35054 +5
Misses 5070 5070
+ Partials 1094 1093 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add fides_revision, is_managed, parent_template_id columns. Remove deprecated key column. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Fix downgrade to restore single unique index (not constraint + non-unique index) - Add partial unique index uq_assessment_template_active_type ensuring only one active template per assessment_type at DB level Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Column("is_active").is_(True) doesn't type-check in Index kwargs.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
thabofletcher
approved these changes
Apr 20, 2026
Contributor
thabofletcher
left a comment
There was a problem hiding this comment.
Approved when tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3481
Description Of Changes
Add template versioning support to the assessment_template schema and seed new/updated assessment templates.
Templates are now versioned on three axes:
assessment_type: template family (e.g.,us_ca_cpra_risk_assessment)version: regulatory version string (e.g.,US-CA-CPPA-RA-2025-09-23)fides_revision: Ethyca iteration count within that regulatory version (integer)Only one template per
assessment_typeisis_active=trueat a time. Existing assessments linked to old templates are preserved and continue to work via theirtemplate_idFK.Code Changes
fides_revision(Integer),is_managed(Boolean),parent_template_id(nullable FK) columns toassessment_templatekeycolumnuq_assessment_template_type_version_revisionon(assessment_type, version, fides_revision)Steps to Confirm
See fidesplus PR for end-to-end verification: https://github.com/ethyca/fidesplus/pull/3439
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works