Fix user invite email test assertion after HTML escaping update#7973
Merged
Fix user invite email test assertion after HTML escaping update#7973
Conversation
PR #7957 updated user_invite.html to use proper HTML attribute quoting (quoted href, &) but didn't update the test assertion. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
erosselli
approved these changes
Apr 20, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7973 +/- ##
==========================================
+ Coverage 83.39% 85.05% +1.65%
==========================================
Files 631 631
Lines 41213 41213
Branches 4807 4807
==========================================
+ Hits 34371 35052 +681
+ Misses 5637 5069 -568
+ Partials 1205 1092 -113 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
PR #7957 (ENG-3455) updated
user_invite.htmlto use proper HTML attribute quoting — quotedhrefvalue and&entity — but didn't update the test assertion inmessage_dispatch_service_test.py. This fixes the test to match the correctly escaped template output.Before (test expected):
<a href=http://localhost:3000/login?invite_code=123&username=test>After (test expects):
<a href="http://localhost:3000/login?invite_code=123&username=test">Code Changes
tests/ops/service/messaging/message_dispatch_service_test.py— Updated expected HTML body intest_email_dispatch_user_invite_emailto match the properly escaped templateSteps to Confirm
pytest tests/ops/service/messaging/message_dispatch_service_test.py::TestMessageDispatchService::test_email_dispatch_user_invite_emailPre-Merge Checklist
CHANGELOG.mdupdated