Skip to content

Fix user invite email test assertion after HTML escaping update#7973

Merged
JadeCara merged 2 commits intomainfrom
fix/user-invite-email-test
Apr 20, 2026
Merged

Fix user invite email test assertion after HTML escaping update#7973
JadeCara merged 2 commits intomainfrom
fix/user-invite-email-test

Conversation

@JadeCara
Copy link
Copy Markdown
Contributor

@JadeCara JadeCara commented Apr 20, 2026

Description Of Changes

PR #7957 (ENG-3455) updated user_invite.html to use proper HTML attribute quoting — quoted href value and & entity — but didn't update the test assertion in message_dispatch_service_test.py. This fixes the test to match the correctly escaped template output.

Before (test expected): <a href=http://localhost:3000/login?invite_code=123&username=test>
After (test expects): <a href="http://localhost:3000/login?invite_code=123&amp;username=test">

Code Changes

  • tests/ops/service/messaging/message_dispatch_service_test.py — Updated expected HTML body in test_email_dispatch_user_invite_email to match the properly escaped template

Steps to Confirm

  1. Run pytest tests/ops/service/messaging/message_dispatch_service_test.py::TestMessageDispatchService::test_email_dispatch_user_invite_email
  2. Test should pass
  3. No change in rendering
Screenshot 2026-04-20 at 3 23 29 PM

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • No UX review needed
  • Followup issues:
    • No followup issues
  • Database migrations:
    • No migrations
  • Documentation:
    • No documentation updates required

PR #7957 updated user_invite.html to use proper HTML attribute
quoting (quoted href, &amp;) but didn't update the test assertion.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Apr 20, 2026 9:25pm
fides-privacy-center Ignored Ignored Apr 20, 2026 9:25pm

Request Review

@JadeCara JadeCara requested a review from gilluminate April 20, 2026 21:17
@JadeCara JadeCara marked this pull request as ready for review April 20, 2026 21:20
@JadeCara JadeCara enabled auto-merge April 20, 2026 21:25
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.05%. Comparing base (e21ef4d) to head (76fad1e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7973      +/-   ##
==========================================
+ Coverage   83.39%   85.05%   +1.65%     
==========================================
  Files         631      631              
  Lines       41213    41213              
  Branches     4807     4807              
==========================================
+ Hits        34371    35052     +681     
+ Misses       5637     5069     -568     
+ Partials     1205     1092     -113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JadeCara JadeCara added this pull request to the merge queue Apr 20, 2026
Merged via the queue into main with commit b5b98e6 Apr 20, 2026
69 checks passed
@JadeCara JadeCara deleted the fix/user-invite-email-test branch April 20, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants