Skip to content

Restore webpack for Next builds#8022

Merged
gilluminate merged 1 commit intomainfrom
gill/revert-turbopack
Apr 23, 2026
Merged

Restore webpack for Next builds#8022
gilluminate merged 1 commit intomainfrom
gill/revert-turbopack

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

Partially reverts commit 1cb376e.

Description Of Changes

Turbopack's chunk filename scheme is not publicly documented and there is no turbopack config option for chunk filenames. We're going to revert back to using webpack for the release while we continue to determine the best approach to support Turboback in our system.

Code Changes

  • Adds --webpack flag to each Next build command

Steps to Confirm

  1. Run npm run prod-export from Admin UI
  2. Run a local fidesplus slim server
  3. load http://localhost:8080/
  4. Ensure there are no Unexpected token '<' errors in the console

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Apr 23, 2026 5:09pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Apr 23, 2026 5:09pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Dependency Review

✅ No vulnerabilities found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 1154e0c.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Partially reverts commit 1cb376e.
@gilluminate gilluminate force-pushed the gill/revert-turbopack branch from e696c4c to 1154e0c Compare April 23, 2026 17:02
@gilluminate gilluminate marked this pull request as ready for review April 23, 2026 17:02
@gilluminate gilluminate requested a review from a team as a code owner April 23, 2026 17:02
@gilluminate gilluminate requested review from lucanovera and removed request for a team April 23, 2026 17:02
@github-actions
Copy link
Copy Markdown

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.33% (2799/44163) 5.58% (1402/25082) 4.43% (579/13060)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

Copy link
Copy Markdown
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed build works correctly now. Let's revert to webpack until we sort out the problems with out custom routing.
Image

@gilluminate gilluminate added this pull request to the merge queue Apr 23, 2026
Merged via the queue into main with commit 1984f4b Apr 23, 2026
53 of 54 checks passed
@gilluminate gilluminate deleted the gill/revert-turbopack branch April 23, 2026 17:24
gilluminate added a commit that referenced this pull request Apr 23, 2026
gilluminate added a commit that referenced this pull request Apr 28, 2026
JadeCara pushed a commit that referenced this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants