Skip to content

ENG-3528: Update FE to match BE disclosure metrics API contract#8025

Merged
eastandwestwind merged 4 commits into
mainfrom
privacy-request-metrics-be
Apr 24, 2026
Merged

ENG-3528: Update FE to match BE disclosure metrics API contract#8025
eastandwestwind merged 4 commits into
mainfrom
privacy-request-metrics-be

Conversation

@eastandwestwind
Copy link
Copy Markdown
Contributor

@eastandwestwind eastandwestwind commented Apr 24, 2026

Summary

  • Update FE to match simplified BE API contract — GET /plus/privacy-request-metrics now takes no query params (BE hardcodes previous calendar year + California filtering)
  • Remove date range and location params from RTK Query endpoint and component

Depends on fidesplus PR #3455 for the backend endpoint.

Code Changes

  • privacy-request-metrics.slice.ts — RTK Query endpoint now takes void (no params)
  • PrivacyRequestMetrics.tsx — Remove query param construction, call hook with no args

Steps to Confirm

  1. Set FIDES_PRIVACY_CENTER__PRIVACY_REQUEST_DISCLOSURE_ENABLED=true
  2. Seed disclosure metrics data via Admin UI seed panel
  3. Visit /privacy-request-metrics — table should show real data from the API
  4. Verify footer link is hidden when env var is not set

🤖 Generated with Claude Code

Remove date range and location params from the RTK Query endpoint
and component. The BE now hardcodes previous calendar year and
California filtering.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Apr 24, 2026 9:26am
fides-privacy-center Ignored Ignored Apr 24, 2026 9:26am

Request Review

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@eastandwestwind eastandwestwind changed the title ENG-3528: Connect privacy request disclosure metrics to BE endpoint ENG-3528: Update FE to match BE disclosure metrics API contract Apr 24, 2026
eastandwestwind and others added 2 commits April 24, 2026 08:51
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.32% (2799/44262) 5.57% (1402/25160) 4.42% (579/13087)
fides-js Coverage: 78%
79.39% (2011/2533) 65.99% (1240/1879) 73.09% (345/472)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

@eastandwestwind eastandwestwind marked this pull request as ready for review April 24, 2026 09:38
@eastandwestwind eastandwestwind requested a review from a team as a code owner April 24, 2026 09:38
@eastandwestwind eastandwestwind requested review from gilluminate and removed request for a team April 24, 2026 09:38
@eastandwestwind eastandwestwind added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit 59f308d Apr 24, 2026
47 checks passed
@eastandwestwind eastandwestwind deleted the privacy-request-metrics-be branch April 24, 2026 15:57
eastandwestwind added a commit that referenced this pull request Apr 24, 2026
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants