Skip to content

Expose consent webhook requests in privacy request search#8037

Merged
Linker44 merged 8 commits into
mainfrom
feat/expose-consent-webhook-requests-filter
Apr 29, 2026
Merged

Expose consent webhook requests in privacy request search#8037
Linker44 merged 8 commits into
mainfrom
feat/expose-consent-webhook-requests-filter

Conversation

@Linker44
Copy link
Copy Markdown
Contributor

@Linker44 Linker44 commented Apr 27, 2026

Ticket ENG-3626

Description

Consent webhook privacy requests were hidden from the request manager with no way to view them. The include_consent_webhook_requests parameter existed internally but was never exposed through the API schema or the UI.

This PR:

  • Adds include_consent_webhook_requests to the PrivacyRequestFilter schema so it can be passed via the POST /privacy-request/search endpoint
  • Adds a "Consent webhooks" toggle switch to the admin UI privacy request filters bar
  • Toggle is off by default (preserving existing behavior), flipping it on includes consent webhook-originated DSRs in the results
image

Code Changes

  • Backend: schemas/privacy_request.py — added field to PrivacyRequestFilter; privacy_request_service.py — passes filter value through to query utils
  • Frontend: PrivacyRequestFilter.ts — added TypeScript type; usePrivacyRequestsFilters.ts — added URL state and query param mapping; PrivacyRequestFiltersBar.tsx — added Switch toggle

Steps to Confirm

  1. Open the Privacy Request manager — verify consent webhook requests are NOT shown by default
  2. Toggle "Consent webhooks" on — verify consent webhook requests now appear in the list
  3. Toggle off — verify they disappear again
  4. Verify the toggle state persists in the URL query params

Pre-Merge Checklist

  • All CI checks pass
  • Change is backwards compatible
  • Reviewed by a team member

…API and UI

Consent webhook privacy requests were hidden from the request manager
with no way to view them. This adds an `include_consent_webhook_requests`
filter to the search API schema and a "Consent webhooks" toggle switch
in the admin UI filters bar.
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Apr 29, 2026 2:57am
fides-privacy-center Ignored Ignored Apr 29, 2026 2:57am

Request Review

@Linker44 Linker44 requested review from Vagoasdf and lucanovera April 27, 2026 21:28
@Linker44 Linker44 marked this pull request as ready for review April 27, 2026 21:28
@Linker44 Linker44 requested review from a team as code owners April 27, 2026 21:28
@Linker44 Linker44 requested review from galvana and removed request for a team April 27, 2026 21:28
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.96%. Comparing base (5378b1c) to head (8090ace).
⚠️ Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (84.96%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8037   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files         633      633           
  Lines       41632    41633    +1     
  Branches     4869     4869           
=======================================
+ Hits        35372    35374    +2     
  Misses       5150     5150           
+ Partials     1110     1109    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 29, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.31% (2800/44305) 5.56% (1404/25229) 4.41% (579/13106)
fides-js Coverage: 78%
79.39% (2011/2533) 65.99% (1240/1879) 73.09% (345/472)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

@Linker44 Linker44 added this pull request to the merge queue Apr 29, 2026
Merged via the queue into main with commit d92bd83 Apr 29, 2026
76 of 77 checks passed
@Linker44 Linker44 deleted the feat/expose-consent-webhook-requests-filter branch April 29, 2026 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants