Skip to content

Fix consent webhook requests not visible on detail page#8059

Merged
Linker44 merged 1 commit intomainfrom
fix/consent-webhook-request-detail
Apr 29, 2026
Merged

Fix consent webhook requests not visible on detail page#8059
Linker44 merged 1 commit intomainfrom
fix/consent-webhook-request-detail

Conversation

@Linker44
Copy link
Copy Markdown
Contributor

Summary

  • When navigating to a privacy request detail page (/privacy-requests/[id]), consent webhook requests returned empty results because the backend search endpoint excludes them by default (include_consent_webhook_requests=false)
  • Skip the consent webhook exclusion filter when a specific request_id is provided, since looking up a request by exact ID should always return it regardless of source

Test plan

  • Navigate to a consent webhook privacy request detail page and confirm it loads
  • Confirm the privacy request list still excludes consent webhook requests by default (unless the checkbox is toggled)

When navigating to a specific privacy request by ID, consent webhook
requests were being filtered out because the search endpoint defaults
include_consent_webhook_requests to false. Skip the consent webhook
exclusion filter when a specific request_id is provided.
@Linker44 Linker44 requested a review from a team as a code owner April 29, 2026 04:53
@Linker44 Linker44 requested review from johnewart and removed request for a team April 29, 2026 04:53
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Apr 29, 2026 4:53am
fides-privacy-center Ignored Ignored Apr 29, 2026 4:53am

Request Review

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.96%. Comparing base (d92bd83) to head (fce0e72).
⚠️ Report is 2 commits behind head on main.

❌ Your project status has failed because the head coverage (84.96%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8059   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files         633      633           
  Lines       41633    41633           
  Branches     4869     4869           
=======================================
  Hits        35374    35374           
  Misses       5150     5150           
  Partials     1109     1109           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Linker44 Linker44 added this pull request to the merge queue Apr 29, 2026
Merged via the queue into main with commit 6cea3cf Apr 29, 2026
69 of 71 checks passed
@Linker44 Linker44 deleted the fix/consent-webhook-request-detail branch April 29, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants