Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
gilluminate
approved these changes
Apr 30, 2026
| return experience.meta.version_hash !== cookie.tcf_version_hash; | ||
| return ( | ||
| experience.meta.version_hash !== cookie.tcf_version_hash || | ||
| shouldResurfaceBasedOnConfiguration |
Contributor
There was a problem hiding this comment.
This is a little buried in the logic tree. Not sure if there's a cleaner solution but maybe consider breaking out as its own if statement (if possible)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3590
Sibling PR: https://github.com/ethyca/fidesplus/pull/3500
Description Of Changes
TCF doesn't resurface when it is configured to resurface on dismiss or reject. This change fixes that.
There is a matching backend change for this code as the minimal TCF endpoint also needs to return the behavior array.
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works