Require integration name when adding from system form#8085
Merged
Conversation
The system form's Integrations tab previously hid the name field and omitted it from the create payload, so integrations created there showed as "(No name)" on the integrations list. Make the field visible and required, send it on create, and pre-fill the name with the connection key for existing nameless integrations so editing them isn't blocked.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
speaker-ender
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3699
Description Of Changes
Previously, when a user added an integration from a system's Integrations tab (
/systems/configure/[id]→ Integrations), the form did not collect a name. Thenamefield was rendered as a hiddenForm.Itemand was explicitly omitted from the create payloads. As a result, those integrations were saved without a name and showed up as "(No name)" on the standalone Integrations list.This change makes the Name field visible and required in the system-form integration form, matching the standalone "Add Integration" flow. It also pre-fills the field with the connection key when editing an existing nameless integration, so users with pre-existing "(No name)" integrations can keep their current key as the name (or rename it) without being blocked from saving / testing / authorizing.
Code Changes
clients/admin-ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParametersForm.tsx:nameForm.Itemwith a visible field usingrules={[{ required: true, message: "Name is required" }]}(matches the styling/validation of the standalone form).initialFormValues, fall back toconnectionConfig.keywhenconnectionConfig.nameis null/empty so existing nameless integrations get a sensible default in the field.clients/admin-ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParameters.tsx:Omit<..., "name">typing on both create payloads (createSaasConnectorandpatchConnectionConfig) and addedname: values.nameso the user-entered name is sent to the backend.Steps to Confirm
/integrationsto confirm it still works as before.Pre-Merge Checklist
CHANGELOG.mdupdateddb-migrationlabel to the entry if your change includes a DB migrationhigh-risklabel to the entry if your change includes a high-risk changemaindowngrade()migration is correct and works