Skip to content

ENG-3457: fix long field name overflow in action center monitor results#8095

Merged
nreyes-dev merged 4 commits into
mainfrom
nreyes/eng-3457
May 6, 2026
Merged

ENG-3457: fix long field name overflow in action center monitor results#8095
nreyes-dev merged 4 commits into
mainfrom
nreyes/eng-3457

Conversation

@nreyes-dev
Copy link
Copy Markdown
Contributor

@nreyes-dev nreyes-dev commented May 4, 2026

Ticket ENG-3457

Description Of Changes

Long field names in the Action Center monitor results overflowed into the Confidence and Actions area on each row, and overflowed off-screen in the resource details drawer header. This PR truncates the field name with an ellipsis in both spots and shows a tooltip with the full name only when truncation actually occurs (matching the existing schema explorer pattern, so short names don't trigger tooltip noise on hover).

Before

image
image

After

image
image

Code Changes

  • Wrapped the row field name in <Text ellipsis={{ tooltip: name }}> and added SCSS rules (min-width: 0 on the title flex, new monitor-field__name rule) so the button can shrink and the inner text can ellipsize.
  • Added Tailwind arbitrary variant [&_.ant-drawer-title]:min-w-0 on DetailsDrawer to override Ant's default min-width: auto on the drawer title slot, which was preventing it from shrinking.
  • Replaced the drawer title <span> with a Tooltip wrapping a truncated span, with a ResizeObserver driving an isTruncated flag that gates the tooltip — Ant's Text ellipsis detection didn't fire reliably in the drawer's animated mount context.
  • Added flex-none to the drawer title icon and tag wrappers so they keep their natural size when the title competes for flex space.
  • Added changelog entry.

Steps to Confirm

  1. Navigate to Detection & Discovery → Action center and click into any datastore monitor.
  2. In the monitor results list, locate a row with a field. In DevTools, edit the visible text inside the row's <span> to a ~200-character all-caps snake_case string to simulate a long field name.
  3. Confirm the row truncates with instead of overflowing into the Confidence indicator and action buttons.
  4. Hover the truncated name and confirm a tooltip appears with the full text.
  5. Hover a short field name (e.g. last_login) and confirm no tooltip appears.
  6. Click the row to open the resource details drawer. Repeat the DevTools text edit on the drawer title's <span> to simulate a long title.
  7. Confirm the drawer title truncates with , the column icon and Unlabeled tag stay visible at full size, and hovering the truncated title shows the tooltip with the full name.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment May 5, 2026 6:40pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored May 5, 2026 6:40pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.64% (3008/45293) 5.96% (1554/26052) 4.65% (622/13354)
fides-js Coverage: 78%
79.43% (2013/2534) 66.13% (1244/1881) 73.09% (345/472)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

@nreyes-dev nreyes-dev marked this pull request as ready for review May 4, 2026 13:32
@nreyes-dev nreyes-dev requested a review from a team as a code owner May 4, 2026 13:32
@nreyes-dev nreyes-dev requested review from gilluminate and removed request for a team May 4, 2026 13:32
@nreyes-dev nreyes-dev added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit bfac5da May 6, 2026
51 checks passed
@nreyes-dev nreyes-dev deleted the nreyes/eng-3457 branch May 6, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants