Skip to content

ENG-3389: Add Jira credential management UI#8098

Merged
jpople merged 7 commits into
mainfrom
jpople/eng-3389/jira-auth-ui
May 6, 2026
Merged

ENG-3389: Add Jira credential management UI#8098
jpople merged 7 commits into
mainfrom
jpople/eng-3389/jira-auth-ui

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented May 4, 2026

Ticket ENG-3389

Description Of Changes

Adds a "Credentials" tab to the Jira integration detail page, allowing users to manage Jira authentication directly from the UI instead of relying on API calls or environment variables.

The tab supports two auth methods:

  • OAuth 2.0 — "Authorize with Jira" button (reuses existing OAuth flow)
  • SaaS credential linking — select an existing Jira SaaS connector and copy its API key credentials to the Jira ticket integration

Also displays credential link status (synced/stale/source missing) with appropriate alerts and an unlink action.

Code Changes

  • Added 4 RTK Query endpoints in plus.slice.ts for SaaS credential linking (get available connections, get link status, link, unlink)
  • Added "Jira Credentials" cache tag in api.slice.ts
  • Created JiraCredentialsTab component with credential status card, OAuth section, and SaaS linking section
  • Registered "Credentials" tab in useFeatureBasedTabs for Jira integrations (before "Ticket setup")
  • Updated barrel export in configure-jira/index.ts

Steps to Confirm

  1. Navigate to a Jira integration detail page
  2. Verify a "Credentials" tab appears between "Connection" and "Ticket setup"
  3. Verify the "Credential status" card shows current auth state
  4. Verify "Authorize with Jira" button initiates OAuth flow
  5. If Jira SaaS connectors exist, verify the linking dropdown populates and link/unlink actions work
  6. If no SaaS connectors exist, verify the empty state message appears

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • No migrations
  • Documentation:
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment May 6, 2026 3:38pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored May 6, 2026 3:38pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.67% (3042/45590) 5.97% (1570/26261) 4.68% (630/13451)
fides-js Coverage: 78%
79.43% (2013/2534) 66.13% (1244/1881) 73.09% (345/472)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

@jpople jpople marked this pull request as ready for review May 5, 2026 07:38
@jpople jpople requested a review from a team as a code owner May 5, 2026 07:38
@jpople jpople requested review from eastandwestwind and speaker-ender and removed request for a team and speaker-ender May 5, 2026 07:38
Copy link
Copy Markdown
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great- I'd just suggest extracting various syncStatus strings into an enum, non-blocking suggestion.

@jpople jpople enabled auto-merge May 6, 2026 15:36
@jpople jpople added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 3ba04ef May 6, 2026
51 checks passed
@jpople jpople deleted the jpople/eng-3389/jira-auth-ui branch May 6, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants