Skip to content

refactor: action center cache busting [ENG-3643]#8104

Merged
speaker-ender merged 2 commits into
mainfrom
refactor/action-center-cache-busting
May 6, 2026
Merged

refactor: action center cache busting [ENG-3643]#8104
speaker-ender merged 2 commits into
mainfrom
refactor/action-center-cache-busting

Conversation

@speaker-ender
Copy link
Copy Markdown
Contributor

@speaker-ender speaker-ender commented May 5, 2026

Ticket ENG-3643

Description Of Changes

Calls the cache refresh endpoint when actions are taken from the root action center

Code Changes

Steps to Confirm

  1. Classify the results of a monitor
  2. Open the findings section of the monitor from the root action center screen
  3. Click on the Approve button and confirm the action from the confirmation modal.
  4. Confirm that the refresh endpoint is triggered after the approve action has completed

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment May 6, 2026 2:36pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored May 6, 2026 2:36pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.6% (3007/45513) 5.92% (1554/26209) 4.63% (622/13434)
fides-js Coverage: 78%
79.43% (2013/2534) 66.13% (1244/1881) 73.09% (345/472)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

@speaker-ender speaker-ender force-pushed the refactor/action-center-cache-busting branch from 359f29d to d6d1632 Compare May 5, 2026 13:14
@speaker-ender speaker-ender marked this pull request as ready for review May 5, 2026 13:27
@speaker-ender speaker-ender requested a review from a team as a code owner May 5, 2026 13:27
@speaker-ender speaker-ender requested review from lucanovera and removed request for a team May 5, 2026 13:27
refactor: adding in monitor id

chore: update changelog
Copy link
Copy Markdown
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the refresh got called correctly. Code changes look good. Approved.
Image

I want to callout this bad request I've seen in the preview link and locally as well, I think it's worth investigating the cause.
Image

@speaker-ender speaker-ender added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 45c64d2 May 6, 2026
51 checks passed
@speaker-ender speaker-ender deleted the refactor/action-center-cache-busting branch May 6, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants