Skip to content

Cypress test flakiness fixes#8114

Merged
gilluminate merged 1 commit into
mainfrom
gill/cypress-test-flakiness
May 6, 2026
Merged

Cypress test flakiness fixes#8114
gilluminate merged 1 commit into
mainfrom
gill/cypress-test-flakiness

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate commented May 5, 2026

Description Of Changes

Cypress sometimes gets hung up trying to accomplish the drag/drop in the column reordering. This PR addresses that flakiness

Code Changes

  • Remove the datatransfer stuff
  • Remove dragover event
  • Make sure save gets clicked using force

Steps to Confirm

  1. CI passes

Pre-Merge Checklist

  • All CI pipelines succeeded

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment May 5, 2026 8:25pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored May 5, 2026 8:25pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.6% (3007/45496) 5.93% (1554/26197) 4.63% (622/13431)
fides-js Coverage: 78%
79.43% (2013/2534) 66.13% (1244/1881) 73.09% (345/472)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

@gilluminate gilluminate marked this pull request as ready for review May 5, 2026 20:58
@gilluminate gilluminate requested a review from a team as a code owner May 5, 2026 20:58
@gilluminate gilluminate requested review from lucanovera and removed request for a team May 5, 2026 20:58
@gilluminate gilluminate added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 1db6255 May 6, 2026
50 of 51 checks passed
@gilluminate gilluminate deleted the gill/cypress-test-flakiness branch May 6, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants