Eng 3003 date of birth as Identity#8143
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Dependency ReviewThe following issues were found:
Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned Files
|
15046f8 to
9f03f83
Compare
…validation shows up
lucanovera
approved these changes
May 18, 2026
Contributor
lucanovera
left a comment
There was a problem hiding this comment.
Nice work! The feature works as expected and the code changes look good.
I made a small tweak to fix the full width class on the date picker that wasn't working:


Regarding the display date format, I'd advise you to consider for a followup if a MM/DD/YYYY format would be more appropriate here. That would apply if this feature is intended for a US audience. In admin-ui we've been using that format too, although it might be time we have a setting for that, I'll create a ticket.
I'd also advise to run the thorough security review skill on the backend changes for this as it touches on a sensitive logic such as identity resolution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3003
Description Of Changes
Adding Date of birth as an custom identity, alongisde with a Date Picker component so we can pass it to privacy requests up the line
This is in the context of a custom Dynamics CRM integration that would require a secondary identity besides the email for the cases where multiple contacts share the same email, (I.E a household all inscribed under the same email originally).
Code Changes
clients/privacy-center/components/common/CustomFieldRenderer.tsxSteps to Confirm
identity_inputsfor one of the actions:Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works