Skip to content

Eng 3003 date of birth as Identity#8143

Merged
Vagoasdf merged 23 commits into
mainfrom
ENG-3003_date-of-birth-second-setup
May 19, 2026
Merged

Eng 3003 date of birth as Identity#8143
Vagoasdf merged 23 commits into
mainfrom
ENG-3003_date-of-birth-second-setup

Conversation

@Vagoasdf
Copy link
Copy Markdown
Contributor

@Vagoasdf Vagoasdf commented May 8, 2026

Ticket ENG-3003

Description Of Changes

Adding Date of birth as an custom identity, alongisde with a Date Picker component so we can pass it to privacy requests up the line

This is in the context of a custom Dynamics CRM integration that would require a secondary identity besides the email for the cases where multiple contacts share the same email, (I.E a household all inscribed under the same email originally).

Code Changes

  • Adding date as a possible custom field type on clients/privacy-center/components/common/CustomFieldRenderer.tsx
  • Adding validation for date of birth field
  • Adding the field to hooks and types

Steps to Confirm

  1. Include the following on the config.json file of the privacy center, on the identity_inputs for one of the actions:
 "date_of_birth": {
          "label": "Date of Birth",
          "field_type": "date",
          "required": true
        }
  1. Go to the privacy action center
  2. Verify that the date of birth shows on the desired action
  3. Emit an DSR with that action
  4. On the Admin suite, verify that the privacy request shows the date as an identity

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment May 18, 2026 9:22pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored May 18, 2026 9:22pm

Request Review

@Vagoasdf Vagoasdf changed the title Eng 3003 date of birth second setup Eng 3003 date of birth as Identity May 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
See the Details below.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA db92983.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

  • clients/package-lock.json
  • clients/privacy-center/package.json

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 9%
6.94% (3176/45763) 6.35% (1682/26485) 4.8% (651/13542)
fides-js Coverage: 78%
79.17% (1977/2497) 66.25% (1249/1885) 73.31% (349/476)
privacy-center Coverage: 85%
82.53% (364/441) 79.74% (189/237) 74.07% (60/81)

@Vagoasdf Vagoasdf force-pushed the ENG-3003_date-of-birth-second-setup branch from 15046f8 to 9f03f83 Compare May 11, 2026 16:13
@Vagoasdf Vagoasdf marked this pull request as ready for review May 11, 2026 18:24
@Vagoasdf Vagoasdf requested a review from a team as a code owner May 11, 2026 18:24
@Vagoasdf Vagoasdf requested review from lucanovera and removed request for a team May 11, 2026 18:24
Copy link
Copy Markdown
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! The feature works as expected and the code changes look good.
I made a small tweak to fix the full width class on the date picker that wasn't working:
Image
Image

Regarding the display date format, I'd advise you to consider for a followup if a MM/DD/YYYY format would be more appropriate here. That would apply if this feature is intended for a US audience. In admin-ui we've been using that format too, although it might be time we have a setting for that, I'll create a ticket.

I'd also advise to run the thorough security review skill on the backend changes for this as it touches on a sensitive logic such as identity resolution.

@Vagoasdf Vagoasdf added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 605b268 May 19, 2026
51 of 52 checks passed
@Vagoasdf Vagoasdf deleted the ENG-3003_date-of-birth-second-setup branch May 19, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants