Skip to content

Update the cookie wildcard placeholder#8152

Merged
guncha merged 2 commits into
mainfrom
ga/ENG-3760/update-cookie-name-wildcard
May 11, 2026
Merged

Update the cookie wildcard placeholder#8152
guncha merged 2 commits into
mainfrom
ga/ENG-3760/update-cookie-name-wildcard

Conversation

@guncha
Copy link
Copy Markdown
Contributor

@guncha guncha commented May 9, 2026

Ticket ENG-3760

Description Of Changes

There was a change upstream to consolidate the wildcard placeholders ([id] for cookies and paths, _id_ for domains) into -id- which is valid in all of the possible positions and I forgot to update this cookie handling code. Thanks @nrxsmith for catching this.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated

@guncha guncha requested a review from a team as a code owner May 9, 2026 19:53
@guncha guncha requested review from gilluminate and removed request for a team May 9, 2026 19:53
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview May 9, 2026 7:54pm
fides-privacy-center Ignored Ignored May 9, 2026 7:54pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.68% (3082/46073) 6.04% (1604/26541) 4.67% (636/13617)
fides-js Coverage: 78%
79.51% (2019/2539) 66.24% (1248/1884) 73.31% (349/476)
privacy-center Coverage: 85%
82.53% (364/441) 79.74% (189/237) 74.07% (60/81)

@guncha guncha added this pull request to the merge queue May 11, 2026
Merged via the queue into main with commit dbb927f May 11, 2026
45 checks passed
@guncha guncha deleted the ga/ENG-3760/update-cookie-name-wildcard branch May 11, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants