Build dependencies automatically when running turbo run dev#8157
Merged
lucanovera merged 2 commits intoMay 11, 2026
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
gilluminate
approved these changes
May 11, 2026
Vagoasdf
pushed a commit
that referenced
this pull request
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3770
Description Of Changes
The
devtask inclients/turbo.jsonhad nodependsOn, soturbo run devfanned out to every workspace in parallel with no ordering guarantee. Becausefides-js's rollup config writes its bundles directly intoclients/privacy-center/public/lib/andclients/admin-ui/public/lib/, this meant that when you switched to a branch withfides-jschanges and started the dev servers, the Next dev servers could (and did) start serving the previous branch's bundles — privacy-center's/api/fides-jsroute readspublic/lib/fides.json first request and caches it in memory for the rest of the process lifetime.Adding
"dependsOn": ["^build"]to thedevtask tells turbo: before startingdevon any workspace, finishbuildon all of its workspace dependencies first. For admin-ui and privacy-center (both of which declare"fides-js": "*"), that meansfides-js's rollup build runs and writes fresh bundles into the consumerpublic/lib/directories before the Next dev servers come up.Notes:
dev:windowsin the same file.outputs: ["dist/**"]on thebuildtask — iffides-jssources haven't changed, the prerequisite is essentially free.fides-js'sdevscript (rollup --watch) still runs as part of thedevfan-out, so live reloading during the session continues to work.clients/privacy-center/pages/api/fides-js.ts— mid-session edits tofides-jsstill require restarting the Next dev server to pick up. That's a pre-existing issue and out of scope here.Code Changes
"dependsOn": ["^build"]to thedevtask inclients/turbo.json.Steps to Confirm
clients/, runturbo run dev.fides-js#buildtask running (or cached) beforeadmin-ui#dev/privacy-center#devstart their Next servers.http://localhost:3000(admin-ui) andhttp://localhost:3001(privacy-center) and confirm both load normally.Ctrl+Cin the terminal running turbo (one Ctrl+C stops the whole turbo run and all child processes).fides-jsbefore serving:clients/fides-js/src/fides.ts, e.g.console.log("FIDES_JS_BUILD_TEST_MARKER");just after the imports.clients/, runturbo run dev.admin-ui#dev/privacy-center#devare ready, openhttp://localhost:3001/fides.jsin a browser tab (orcurl http://localhost:3001/fides.js | grep FIDES_JS_BUILD_TEST_MARKER) and confirm the marker string is present in the served bundle on the first request — i.e. without waiting for the rollup watcher to pick up a later change.Ctrl+Cto stop. Revert the marker line before committing.Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works