ENG-3303: Generate TS types for correspondence API contract#8159
Merged
Conversation
Create two new service packages following the established Jira polling pattern. Each provides a module-level register function, a Celery task with Redis lock, and APScheduler wiring — all no-ops until Fidesplus registers an implementation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The notify task is now the primary delivery path — called directly by DSR lifecycle code with a privacy_request_id and event_type. The sweep_notifications task runs on a scheduled interval as a catch-all for missed or failed notifications. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add "set once at startup" comments on module-level hook variables - Add exception propagation tests for all registered service functions - Clarify relationship to messaging/ package in __init__.py docstrings Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Rename notify → send_dsr_notification for clarity in Celery logs/queues - Document fork vs thread propagation constraint on hook registration - Document why send_dsr_notification intentionally has no Redis lock Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add frontend type definitions for the correspondence and notification schemas so FE development can start in parallel with MSW mocks. New types: CorrespondenceDeliveryStatus, NotificationResponse, UnreadCountResponse, Page_NotificationResponse_ Updated: CommentResponse (6 new optional fields), index.ts exports Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
New types: MarkAllReadResponse, NotificationType enum, NotificationResourceType enum, ErrorResponse, Body_send_correspondence (multipart FormData shape). Updated: NotificationResponse now uses typed enums instead of plain strings for notification_type and resource_type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Base automatically changed from
ENG-3302/hook-skeleton-polling-notifications
to
main
May 13, 2026 20:40
Add lazy="selectin" so listing comments batches metadata loading into a single IN query instead of one query per comment. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Matches the read_at: datetime | None field added to the Pydantic schema in fidesplus PR #3554. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
JadeCara
requested review from
gilluminate,
lucanovera and
vcruces
and removed request for
a team and
lucanovera
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8159 +/- ##
=======================================
Coverage 85.61% 85.61%
=======================================
Files 658 658
Lines 42858 42858
Branches 5016 5016
=======================================
Hits 36691 36691
Misses 5063 5063
Partials 1104 1104 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gilluminate
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generate frontend TypeScript types for the correspondence and notification schemas defined in fidesplus#3554, so FE development can start in parallel with MSW mocks.
Code Changes
CorrespondenceDeliveryStatus(enum),NotificationResponse,UnreadCountResponse,Page_NotificationResponse_CommentResponse— 6 new optional fields (delivery_status,parent_id,sender_email,recipient_email,bounce_reason,reply_to_address)index.ts— added exports for all new typesSteps to Confirm
CommentResponse.tsincludes the 6 new optional fieldsCorrespondenceDeliveryStatus.tshas 5 enum values (pending, sent, delivered, bounced, failed)NotificationResponse.tshas 9 fields (id, notification_type, title, body, resource_type, resource_id, is_read, read_at, created_at)UnreadCountResponse.tshascount: numberindex.tsPre-Merge Checklist
🤖 Generated with Claude Code