ENG-2907: Add Source filter to Request Manager#8161
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8161 +/- ##
==========================================
+ Coverage 85.23% 85.61% +0.37%
==========================================
Files 638 658 +20
Lines 42011 42869 +858
Branches 4937 5019 +82
==========================================
+ Hits 35808 36702 +894
+ Misses 5096 5063 -33
+ Partials 1107 1104 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/code-review |
gilluminate
requested changes
May 13, 2026
johnewart
approved these changes
May 15, 2026
Collaborator
johnewart
left a comment
There was a problem hiding this comment.
Nothing blocking, just 2 questions; seems like we could make the filter a lot simpler to reason about but it's not a show-stopper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2907
Description Of Changes
Adds a
Sourcemulti-select filter to the Request Manager dashboard, exposing allPrivacyRequestSourceenum values (Privacy Center, Request Manager, Consent Webhook, Fides.js, Dataset Test, Janus SDK). DSRs with aNULLsource remain visible when no filter is applied.The existing default exclusion guards for
consent_webhook(toggle-gated) anddataset_test(always-on) are bypassed when an explicitsourcefilter is set, so a user who selects those values in the dropdown gets them in the results instead of an empty list.Code Changes
sourcefield and a single-to-list validator toPrivacyRequestFilterschema.sourceclause tofilter_privacy_request_queryset; gated the consent_webhook and dataset_test exclusion guards onnot filters.sourceso explicit filters win.sourceas a repeatable query param on the deprecatedGET /privacy-requestendpoint.SubjectRequestSourceMap/SubjectRequestSourceOptionsconstants and a Source multi-select toPrivacyRequestFiltersBar.sourcetoFilterQueryParams, the nuqs URL state, and memoized params inusePrivacyRequestsFilters.sourceto the generatedPrivacyRequestFilterTS type and updatedPrivacyRequestFiltersBartest fixtures.Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works