Skip to content

Eng 3496 improve ux saas validation#8166

Merged
Vagoasdf merged 8 commits into
mainfrom
ENG-3496-improve-ux-saas-validation
May 19, 2026
Merged

Eng 3496 improve ux saas validation#8166
Vagoasdf merged 8 commits into
mainfrom
ENG-3496-improve-ux-saas-validation

Conversation

@Vagoasdf
Copy link
Copy Markdown
Contributor

@Vagoasdf Vagoasdf commented May 12, 2026

Ticket ENG-3496

Description Of Changes

Improving view of SaaShistory using the improved YAML editor available at fides

imagen

Adding aswell a copy to clipboard functionality for ease of debug and sharing information with technical staff

Code Changes

  • Created a new component, EditorWithCopy, to extend the YAML editor
  • Used the editor on the newer version history pages with read only capabilities

Steps to Confirm

  1. Set up a new integration
  2. Check that the version history tab on the integration page is using the YAML editor
  3. Create a new DSR
  4. Check that the DSR view is using the YAML editor

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 12, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment May 18, 2026 9:27pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored May 18, 2026 9:27pm

Request Review

@Vagoasdf Vagoasdf marked this pull request as ready for review May 13, 2026 17:01
@Vagoasdf Vagoasdf requested a review from a team as a code owner May 13, 2026 17:01
@Vagoasdf Vagoasdf requested review from jpople and removed request for a team May 13, 2026 17:01
@Vagoasdf Vagoasdf force-pushed the ENG-3496-improve-ux-saas-validation branch from 5de2d04 to 5183212 Compare May 13, 2026 19:34
@Vagoasdf Vagoasdf requested a review from a team as a code owner May 13, 2026 19:34
@Vagoasdf Vagoasdf requested review from erosselli and removed request for a team May 13, 2026 19:34
@github-actions
Copy link
Copy Markdown

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
See the Details below.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 5183212.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

  • clients/admin-ui/package.json
  • clients/fides-js/package.json
  • clients/package-lock.json
  • clients/privacy-center/package.json

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 9%
6.95% (3183/45759) 6.34% (1681/26485) 4.82% (654/13541)
fides-js Coverage: 78%
79.17% (1977/2497) 66.25% (1249/1885) 73.31% (349/476)
privacy-center Coverage: 85%
82.53% (364/441) 79.74% (189/237) 74.07% (60/81)

@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

❌ Patch coverage is 93.72385% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.47%. Comparing base (26cf81d) to head (5183212).
⚠️ Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
src/fides/common/engine_creators.py 89.83% 3 Missing and 3 partials ⚠️
...e/messaging/messaging_providers/aws_ses_service.py 92.53% 4 Missing and 1 partial ⚠️
src/fides/api/v1/endpoints/messaging_endpoints.py 50.00% 4 Missing ⚠️

❌ Your patch check has failed because the patch coverage (93.72%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8166      +/-   ##
==========================================
+ Coverage   85.40%   85.47%   +0.07%     
==========================================
  Files         649      651       +2     
  Lines       42283    42434     +151     
  Branches     4960     4982      +22     
==========================================
+ Hits        36112    36272     +160     
+ Misses       5063     5055       -8     
+ Partials     1108     1107       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Vagoasdf Vagoasdf removed request for erosselli and jpople May 13, 2026 20:12
@Vagoasdf
Copy link
Copy Markdown
Contributor Author

Hold, Branch history got really polluted, fixing it before re-requesting review

@Vagoasdf Vagoasdf force-pushed the ENG-3496-improve-ux-saas-validation branch from 5183212 to f32b826 Compare May 13, 2026 20:15
@Vagoasdf Vagoasdf requested a review from jpople May 13, 2026 20:34
Copy link
Copy Markdown
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple code nits, but overall looking good, I won't block merge on this.

{ ssr: false },
);

export const EditorWithCopy = ({ yaml }: { yaml: string }) => (
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit weird to be making this its own component, do we feel like this is likely to get used elsewhere or is it just a one-off? If the latter I might prefer just inlining the copy button.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a One off for now, so it makes sense to just inline it, will do now

return <YamlBlock yaml={configYaml} />;
if (!configYaml) {
return (
<Text type="secondary" className="text-sm">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Text type="secondary" className="text-sm">
<Text type="secondary" >

Generally prefer not using Tailwind for text size, Ant doesn't offer an API to directly change size but I think it's fine to have this at the default size.

@Vagoasdf Vagoasdf added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit e5417f9 May 19, 2026
51 checks passed
@Vagoasdf Vagoasdf deleted the ENG-3496-improve-ux-saas-validation branch May 19, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants