Add Snowflake VARIANT JSON integration tests#8173
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Dependency ReviewThe following issues were found:
Scanned Files
|
Adds a fixture that inserts actual nested JSON (with objects and arrays) into the VARIANT column via parse_json(), and two new tests verifying that access requests return the full JSON structure and erasure requests nullify it. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
eastandwestwind
force-pushed
the
snowflake-variant-json-tests
branch
from
4d7c4cd to
3b9ba8a
Compare
eastandwestwind
added
the
run unsafe ci checks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8173 +/- ##
==========================================
- Coverage 85.47% 85.46% -0.01%
==========================================
Files 650 650
Lines 42416 42416
Branches 4980 4980
==========================================
- Hits 36253 36252 -1
Misses 5055 5055
- Partials 1108 1109 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
gilluminate
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
snowflake_resources_with_json_variant) that inserts actual nested JSON into the Snowflake VARIANT column usingparse_json()instead ofto_variant()on a plain stringtest_access_request_snowflake_with_json_variant— verifies nested JSON objects and arrays are returned in the DSR access packagetest_erasure_request_snowflake_with_json_variant— verifies the VARIANT column containing nested JSON is nullified after an erasure requestTest plan
pytest tests/ops/service/privacy_request/test_snowflake_privacy_requests.py -m "integration_snowflake"🤖 Generated with Claude Code