Skip to content

Make RTK 404 less annoying in CLI logs#8187

Merged
gilluminate merged 3 commits into
mainfrom
gill/lighten-rtk-404
May 14, 2026
Merged

Make RTK 404 less annoying in CLI logs#8187
gilluminate merged 3 commits into
mainfrom
gill/lighten-rtk-404

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

No Ticket

Description Of Changes

Some 404s are expected from our endpoints depending on permissions/authentication/data, especially as we are working with multiple branches during development. These get surfaced all the way to the CLI logs and look far scarier than they need to.

  • Turns those in to a 1 line message instead of ignoring completely
  • Turns those in to a warning instead of an error
  • Only errors will surface to the CLI logs

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview May 14, 2026 8:20pm
fides-privacy-center Ignored Ignored May 14, 2026 8:20pm

Request Review

@gilluminate gilluminate requested a review from erosselli May 14, 2026 20:12
@gilluminate gilluminate marked this pull request as ready for review May 14, 2026 20:12
@gilluminate gilluminate requested a review from a team as a code owner May 14, 2026 20:12
@gilluminate gilluminate requested review from speaker-ender and removed request for a team and speaker-ender May 14, 2026 20:12
@github-actions
Copy link
Copy Markdown

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.72% (3058/45497) 6.07% (1596/26289) 4.69% (633/13481)
fides-js Coverage: 78%
79.17% (1977/2497) 66.25% (1249/1885) 73.31% (349/476)
privacy-center Coverage: 85%
82.53% (364/441) 79.74% (189/237) 74.07% (60/81)

@gilluminate gilluminate enabled auto-merge May 14, 2026 20:27
@gilluminate gilluminate added this pull request to the merge queue May 14, 2026
Merged via the queue into main with commit e537341 May 14, 2026
51 checks passed
@gilluminate gilluminate deleted the gill/lighten-rtk-404 branch May 14, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants