Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8189 +/- ##
==========================================
+ Coverage 85.10% 85.12% +0.01%
==========================================
Files 669 670 +1
Lines 43370 43415 +45
Branches 5080 5081 +1
==========================================
+ Hits 36911 36957 +46
Misses 5351 5351
+ Partials 1108 1107 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
adamsachs
approved these changes
May 19, 2026
Contributor
adamsachs
left a comment
There was a problem hiding this comment.
this looks good to me. only real question is around the SQLAlchemy event hook - i always feel a bit unsure about that approach. but not sure there's anything else right now that makes more sense. i'd maybe just leave a note in the docstring that it could be worth revisiting as we look to productionize this functionality 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket ENG-3250
Description Of Changes
Context: The cloud infra monitor discovers AWS resources (S3, RDS, DynamoDB) and stages them as
CloudInfraStagedResourcerecords. Unlike IDP monitors where promotion is 1:1 (one app = one System), cloud infra uses a many-to-many model: N resources can belong to M Systems, since a shared resource (e.g. a common RDS instance) may serve multiple business applications. The spike atfidesplus/docs/plans/cloud_infra_resource_grouping_spike.mdcovers the full design.This PR adds the ORM models and migration for resource grouping — the data layer that enables users to group cloud infra resources into logical collections that map to Systems. Subsequent PRs will add the service layer, API endpoints, and promotion logic.
Two new tables:
cloud_infra_group— a named group targeting a new System (viadraft_system_name) or an existing one (viasystem_id)cloud_infra_group_assignment— join table linking resources to groups (many-to-many), with apromotedflag per assignment tracking whether each resource has been promoted within that specific groupCode Changes
CloudInfraGroupandCloudInfraGroupAssignmentinfides/api/models/detection_discovery/cloud_infra_group.py(monitor_config_id, system_id)wheresystem_id IS NOT NULL— a System can only have one group per monitordb_dataset.ymlwith entries for both tablesdetection_discovery/__init__.pySteps to Confirm
alembic upgrade head— both tables created successfullyalembic downgrade -1— both tables dropped cleanlyPre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works