ENG-1958: Add TCF version hash history table and model#8200
Merged
Conversation
reneruck-ethyca
requested review from
dsill-ethyca
and removed request for
a team
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
reneruck-ethyca
force-pushed
the
eng-1958-tcf-hash-history
branch
3 times, most recently
from
7b1affb to
d9be396
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8200 +/- ##
==========================================
+ Coverage 85.63% 85.65% +0.02%
==========================================
Files 661 662 +1
Lines 42942 42969 +27
Branches 5027 5027
==========================================
+ Hits 36773 36805 +32
+ Misses 5064 5060 -4
+ Partials 1105 1104 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
reneruck-ethyca
force-pushed
the
eng-1958-tcf-hash-history
branch
from
fd2f7f5 to
1a9ad6d
Compare
erosselli
reviewed
May 18, 2026
Comment on lines
+22
to
+23
| previous_hash = Column(String, nullable=True) | ||
| current_hash = Column(String, nullable=False, index=True) |
Contributor
There was a problem hiding this comment.
How do these work for "global" events like Compass sync? what's the current hash if it's not nullable?
Contributor
Author
There was a problem hiding this comment.
global events like compass sync trigger a re-caching of experiences. The re-caching flow itself already checks if any parts of an experience changed (let me know if that's wrong) and as part of refreshing the cache will re-calculate the hash and track the change per experience config.
erosselli
reviewed
May 18, 2026
reneruck-ethyca
force-pushed
the
eng-1958-tcf-hash-history
branch
4 times, most recently
from
1667c19 to
de0ac8f
Compare
Adds the tcf_version_hash_history table (migration + ORM model) to record hash transitions whenever the TCF experience content changes. Tracks tcf_configuration_id (nullable FK to tcf_configuration, SET NULL on delete) so per-config and global (Compass sync) history chains are isolated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> refactor: use privacy_config_experience_id in TCFVersionHashHistory Replaces privacy_experience_id (FK to privacyexperience) with privacy_config_experience_id (FK to privacyexperienceconfig). Tracking at the config level is more meaningful — all experiences under a config get the same TCF hash, so per-config rows avoid duplicates per region. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
reneruck-ethyca
force-pushed
the
eng-1958-tcf-hash-history
branch
from
de0ac8f to
e4d724b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TCFVersionHashHistorySQLAlchemy model to track changes to TCF configuration hashes over timetcf_version_hash_historytable with columns forid,privacy_config_experience_id,previous_hash,current_hash,changed_at, andtrigger_sourceTest plan
alembic upgrade head— verifytcf_version_hash_historytable is createdprivacyexperiencetablepytest --no-cov tests/targeting models/migrations🤖 Generated with Claude Code