ENG-3714: Form builder base — feature flag, deps, and data layer#8203
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Dependency ReviewThe following issues were found:
Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned Files
|
…, drift, synthesize)
jpople
force-pushed
the
jpople/eng-3714/form-builder-base
branch
from
1012ecf to
516f883
Compare
jpople
requested review from
gilluminate and
lucanovera
and removed request for
a team and
lucanovera
gilluminate
approved these changes
May 19, 2026
Contributor
gilluminate
left a comment
gilluminate
left a comment
There was a problem hiding this comment.
code for the base looks good!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formBuilderfeature flag (dev-only)@dnd-kit/*,@json-render/*,react-phone-number-input,zodproperties/[id].tsx→properties/[id]/index.tsxfor nested routingproperties/[id]/forms/[actionPolicyKey].tsxgated by flagcatalog.ts,mapper.ts,specMutations.ts,drift.ts,synthesize.tswith 36 unit testsTest plan
npm run typecheckpasses (only pre-existing fides-js error)npx jest --testPathPattern="form-builder/__tests__"— 36 tests passformBuilderflag is off[id].tsx→[id]/index.tsxmove