Skip to content

ENG-3714: Form builder registry, SSE streaming, and useFormBuilder hook#8205

Merged
jpople merged 20 commits into
mainfrom
jpople/eng-3714/form-builder-registry-streaming
May 19, 2026
Merged

ENG-3714: Form builder registry, SSE streaming, and useFormBuilder hook#8205
jpople merged 20 commits into
mainfrom
jpople/eng-3714/form-builder-registry-streaming

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented May 15, 2026

Summary

  • Adds registry.tsx — json-render component bindings for all 9 field types
  • Adds LocationField.tsx and PhoneField.tsx with dynamic imports
  • Adds streaming.ts — SSE parser and streamChatTurn fetch wrapper
  • Adds useFormBuilder.ts — state machine hook with sanitizeSpec() security hardening
  • Patches jest.setup.ts for nwsapi/jsdom compat with antd v6

Security

sanitizeSpec() strips elements with unknown component types before rendering in preview, defending against malicious LLM responses.

Test plan

  • npx jest --testPathPattern="(registry|streaming|useFormBuilder)" — all pass
  • Typecheck clean

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment May 19, 2026 8:43pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored May 19, 2026 8:43pm

Request Review

@jpople jpople force-pushed the jpople/eng-3714/form-builder-pc-rendering branch from a1d4a57 to f51cfc5 Compare May 15, 2026 21:40
@jpople jpople force-pushed the jpople/eng-3714/form-builder-registry-streaming branch from a78c25c to b29cd26 Compare May 15, 2026 21:40
@jpople jpople force-pushed the jpople/eng-3714/form-builder-registry-streaming branch from 7e5f107 to 155975b Compare May 19, 2026 15:59
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 10%
7.77% (3602/46326) 6.97% (1870/26809) 5.22% (713/13641)
fides-js Coverage: 78%
79.17% (1977/2497) 66.25% (1249/1885) 73.31% (349/476)
privacy-center Coverage: 85%
82.53% (364/441) 79.74% (189/237) 74.07% (60/81)

@jpople jpople marked this pull request as ready for review May 19, 2026 19:41
@jpople jpople requested a review from a team as a code owner May 19, 2026 19:41
@jpople jpople requested review from gilluminate and removed request for a team May 19, 2026 19:41
Base automatically changed from jpople/eng-3714/form-builder-base to main May 19, 2026 20:27
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpople jpople added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit 39bdf7b May 19, 2026
49 of 51 checks passed
@jpople jpople deleted the jpople/eng-3714/form-builder-registry-streaming branch May 19, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants