ENG-2902: Default ATTRIBUTION_ENABLED to true in Privacy Center#8219
Merged
Conversation
Change the attribution link default from opt-in to opt-out so the Ethyca attribution link is shown unless explicitly disabled via FIDES_PRIVACY_CENTER__ATTRIBUTION_ENABLED=false. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ATTRIBUTION_ENABLEDdefault fromfalsetotruein the Privacy Center, so the Ethyca attribution link is shown by defaultFIDES_PRIVACY_CENTER__ATTRIBUTION_ENABLED=falseTest plan
FIDES_PRIVACY_CENTER__ATTRIBUTION_ENABLED=falsehides the attribution linknpm testinclients/privacy-centerand confirm all tests pass🤖 Generated with Claude Code