Skip to content

ENG-2902: Default ATTRIBUTION_ENABLED to true in Privacy Center#8219

Merged
eastandwestwind merged 4 commits into
mainfrom
ENG-2902
May 19, 2026
Merged

ENG-2902: Default ATTRIBUTION_ENABLED to true in Privacy Center#8219
eastandwestwind merged 4 commits into
mainfrom
ENG-2902

Conversation

@eastandwestwind
Copy link
Copy Markdown
Contributor

Summary

  • Changes the ATTRIBUTION_ENABLED default from false to true in the Privacy Center, so the Ethyca attribution link is shown by default
  • Operators can still disable it by setting FIDES_PRIVACY_CENTER__ATTRIBUTION_ENABLED=false
  • Updates all related tests to reflect the new default behavior

Test plan

  • Verify Privacy Center shows attribution link by default (no env var set)
  • Verify setting FIDES_PRIVACY_CENTER__ATTRIBUTION_ENABLED=false hides the attribution link
  • Run npm test in clients/privacy-center and confirm all tests pass

🤖 Generated with Claude Code

Change the attribution link default from opt-in to opt-out so the
Ethyca attribution link is shown unless explicitly disabled via
FIDES_PRIVACY_CENTER__ATTRIBUTION_ENABLED=false.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview May 18, 2026 3:43pm
fides-privacy-center Ignored Ignored May 18, 2026 3:43pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 9%
6.93% (3173/45766) 6.34% (1680/26489) 4.79% (650/13543)
fides-js Coverage: 78%
79.17% (1977/2497) 66.25% (1249/1885) 73.31% (349/476)
privacy-center Coverage: 85%
82.53% (364/441) 79.74% (189/237) 74.07% (60/81)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@eastandwestwind eastandwestwind marked this pull request as ready for review May 18, 2026 15:43
@eastandwestwind eastandwestwind requested a review from a team as a code owner May 18, 2026 15:43
@eastandwestwind eastandwestwind requested review from kruulik and removed request for a team May 18, 2026 15:43
Copy link
Copy Markdown
Contributor

@kruulik kruulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eastandwestwind eastandwestwind added this pull request to the merge queue May 19, 2026
Merged via the queue into main with commit a288d97 May 19, 2026
45 checks passed
@eastandwestwind eastandwestwind deleted the ENG-2902 branch May 19, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants