ENG-3551: Migrate simplified Privacy Declaration form to antd

[gilluminate]

Ticket ENG-3551

Description Of Changes

Migrates the simplified Privacy Declaration form (the 6-field accordion used inside the data lineage / datamap drawer) from Formik/Chakra/Yup to antd Form. As part of the same diff:

• Renames the whole module to Simplified* to stop shadowing the modal version's filenames and the usePrivacyDeclarationForm hook name (the modal form under system-form-declaration-tab/ had the exact same filenames and hook name, which made navigation and grep painful).
• Extracts shared per-field components into a new features/system/privacy-declaration-fields/ module so ENG-3550 (the modal migration) can consume them next instead of rebuilding each field from scratch.
• Removes dead code that came along for the ride: the legacy onDelete chain (passed through three components but never invoked in this directory), the showNewForm/newDeclaration state machine in the manager (setShowNewForm(true) was never called from anywhere), the isDelete parameter on the save handler (never passed true), and the unused includeCustomFields path (DatamapDrawer never opts in to custom fields). Net delta: -263 lines.

Out of scope for this ticket (will land with ENG-3550):

• privacy-declarations/PrivacyDeclarationStep.tsx — actually mounts the modal PrivacyDeclarationFormTab, not the accordion. Stays as-is.
• privacy-declarations/hooks.ts (usePrivacyDeclarationData) — shared with SystemInformationForm, no rename.
• The Formik-based FormGuard (unsaved-edits navigation guard) is not re-implemented for antd; the simplified drawer flow can live without it for now. May need a follow-up ticket if/when ENG-3550 needs it for the modal.

Code Changes

• clients/admin-ui/src/features/system/privacy-declaration-fields/ — new shared module: DataUseFormItem, DataCategoriesFormItem, DataSubjectsFormItem, DatasetReferencesFormItem, DeclarationNameFormItem, plus index.ts. Each is a thin Form.Item + antd Select/Input pairing with field-local rules. DataSubjectsFormItem takes required?: boolean so ENG-3550's modal can opt out of the min-1 rule.
• clients/admin-ui/src/features/system/privacy-declarations/SimplifiedPrivacyDeclarationForm.tsx — antd Form with Form.useForm<FormValues>(), no Formik, no Yup. Preserves the transformFormValueToDeclaration / transformPrivacyDeclarationToFormValues helpers. Optional renderHeader callback + onSavedChange callback so the accordion wrapper can render its own "Saved" indicator in the Collapse item's extra slot.
• clients/admin-ui/src/features/system/privacy-declarations/SimplifiedPrivacyDeclarationAccordion.tsx — antd Collapse with the items config replacing Chakra Accordion + AccordionItem. Per-item saved state via a savedById map drives the extra indicator.
• clients/admin-ui/src/features/system/privacy-declarations/SimplifiedPrivacyDeclarationManager.tsx — Flex/Typography.Text in place of ChakraStack/ChakraText. Save callback simplified to a single handleEditDeclaration after removing the dead "new declaration" path.
• clients/admin-ui/src/features/datamap/datamap-drawer/DatamapDrawer.tsx — import updated to SimplifiedPrivacyDeclarationManager.
• Deletes: privacy-declarations/PrivacyDeclarationForm.tsx, PrivacyDeclarationAccordion.tsx, PrivacyDeclarationManager.tsx.

Steps to Confirm

1. cd clients/admin-ui && npm run dev (or use the existing dev server).
2. Navigate to /datamap and click any system node — the right-side drawer should open.
3. Scroll to the "Data uses" section. Confirm:
   • Declarations render as an antd Collapse (no Chakra-styled accordion).
   • Each item's header is "<DataUse name> - <declaration name>", or just the data use name if no declaration name.
   • Expanding an item reveals the form with Data use, Processing Activity, Data categories, Data subjects fields, all disabled (matching legacy read-only behavior in this surface).
   • Each field's existing value is populated correctly from the system data.
   • Tooltip info icons render next to each field label.
4. Press Enter in any (enabled) field on a system that has editable declarations — the save toast fires and the "Saved" indicator appears in the right side of the panel header.
5. Switch to a different system node — the previously-selected drawer state resets and the new system's declarations load.
6. Run npm run check from clients/admin-ui — eslint, antd lint, prettier, and tsc all clean.

Pre-Merge Checklist

• Issue requirements met
• All CI pipelines succeeded
• CHANGELOG.md updated (via changelog/8227-simplified-privacy-declaration-form-antd.yaml)
  • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
  • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Updates unreleased work already in Changelog, no new entry necessary
• UX feedback:
  • All UX related changes have been reviewed by a designer
  • No UX review needed (functional parity migration, no new visual design)
• Followup issues:
  • Followup issues created (ENG-3550 will consume the shared field components; a separate ticket may be needed for an antd-aware FormGuard if the modal flow needs it)
  • No followup issues
• Database migrations:
  • Ensure that your downrev is up to date with the latest revision on main
  • Ensure that your downgrade() migration is correct and works
    • If a downgrade migration is not possible for this change, please call this out in the PR description!
  • No migrations
• Documentation:
  • Documentation complete, PR opened in fidesdocs
  • Documentation issue created in fidesdocs
  • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • No documentation updates required

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
fides-plus-nightly	Ignored	Preview	May 18, 2026 10:28pm
fides-privacy-center	Ignored		May 18, 2026 10:28pm

[github-actions]

Title	Lines	Statements	Branches	Functions
admin-ui		6.94% (3174/45715)	6.34% (1680/26461)	4.8% (650/13534)
fides-js		79.17% (1977/2497)	66.25% (1249/1885)	73.31% (349/476)
privacy-center		82.53% (364/441)	79.74% (189/237)	74.07% (60/81)